feat: Add Japanese 106/109 key minimum mappings and extend HID usage range #1036
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IDisposable
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for Japanese 106/109 keyboards.
Keycode Mapping
The keycode handling in WebRTCVideo.tsx was updated to match the existing mappings defined in ui/src/keyboardMappings.ts:
HID Descriptor
The HID keyboard report descriptor was updated to expand LOGICAL_MAXIMUM and USAGE_MAXIMUM from 0x65 to 0xff, allowing international keys (e.g., KeyRO (0x87), Yen (0x89), Henkan (0x8a), Muhenkan (0x8b)) to be reported correctly.