chore: relax jruby-rack requirement to allow compatibility with upcoming 1.3.x #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no known changes needed to be made within warbler to be compatible with upcoming jruby-rack 1.3.x (current
master/HEAD). It already doesn't use any of the removed deprecations.Users themselves who have custom jruby-rack config via
config.webxmlmay need to change that config, however that isn't something abstracted by warbler and they can constrain jruby-rack to a lower version if needed.I've tested warbler locally with jruby-rack 1.3.x:
bundle exec rake specbundle exec rake integrationpointing to 1.3.x jruby-rack jarMaking this change now should allow folks to upgrade jruby-rack without another warbler release needed since it seems compatible as-is.