Skip to content

Add unit tests for /pkg/controller/netns/netns.go #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmesh-bot merged 5 commits into from
Dec 10, 2025
Merged

Add unit tests for /pkg/controller/netns/netns.go #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4e9cab
add unit tests for netns package functionality
adity1raut Dec 9, 2025
8d2f45c
add unit tests for netns package functionality
adity1raut Dec 9, 2025
5cfe467
Add After Review
adity1raut Dec 10, 2025
4ae8ca0
Add After Review
adity1raut Dec 10, 2025
b85e001
solve the confige
adity1raut Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/controller/netns/netns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func FindNetnsForPod(pod *corev1.Pod) (string, error) {
return res, nil
}
}
return "", fmt.Errorf("No matching network namespace found")
return "", fmt.Errorf("no matching network namespace found")
}

func isNotNumber(r rune) bool {
Expand Down Expand Up @@ -121,7 +121,12 @@ func processEntry(proc fs.FS, netnsObserved sets.Set[uint64], filter types.UID,
if err != nil {
return "", nil
}
defer cgroup.Close()
defer func() {
if err := cgroup.Close(); err != nil {
// Log the error or handle it appropriately
log.Errorf("Failed to close cgroup file: %v", err)
}
}()

var cgroupData bytes.Buffer
_, err = io.Copy(&cgroupData, cgroup)
Expand Down
Loading
Loading