Skip to content

Conversation

@robscott
Copy link
Member

@robscott robscott commented Dec 5, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This adds a bunch of guides for features that are not currently documented. These guides are not great, but should be better than nothing. For full disclosure - the majority of this PR was orchestrated by Gemini.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2025
@youngnick
Copy link
Contributor

I think these are good, and can be improved over time - I'd definitely prefer to have some guides about these features rather than the nothing we currently have.

/hold
for other review
/lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@@ -0,0 +1,74 @@
# Cross-Origin Resource Sharing (CORS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some improvement that I would make here, but otherwise LGTM and I would leave it for a followup: I think all of our guide docs could point to the APIReference of the field.

On the bottom of the docs, we mention the other CORS options but would be cool if I could also simply click on some link that takes me to the apiref of it

That said, this can probably be a followup for this and all the other docs

@rikatz
Copy link
Member

rikatz commented Dec 9, 2025

/lgtm
@robscott if you decide to add the APIRef on this PR, let me know, otherwise feel free to unhold and we can discuss about it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants