-
Notifications
You must be signed in to change notification settings - Fork 626
Adding more HTTPRoute guides #4326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45cddcd to
e78777a
Compare
|
I think these are good, and can be improved over time - I'd definitely prefer to have some guides about these features rather than the nothing we currently have. /hold |
| @@ -0,0 +1,74 @@ | |||
| # Cross-Origin Resource Sharing (CORS) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some improvement that I would make here, but otherwise LGTM and I would leave it for a followup: I think all of our guide docs could point to the APIReference of the field.
On the bottom of the docs, we mention the other CORS options but would be cool if I could also simply click on some link that takes me to the apiref of it
That said, this can probably be a followup for this and all the other docs
|
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This adds a bunch of guides for features that are not currently documented. These guides are not great, but should be better than nothing. For full disclosure - the majority of this PR was orchestrated by Gemini.
Does this PR introduce a user-facing change?: