Skip to content

Updating run-capz-e2e.sh to run extra commands #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 11, 2025
Merged

Updating run-capz-e2e.sh to run extra commands #529

k8s-ci-robot merged 1 commit into from
Dec 11, 2025
+38 −1

Conversation

@marosset
Copy link
Contributor

@marosset marosset commented Nov 7, 2025

This is so we can run jobs like the the azuredisk/azurefile csi driver tests using the CAPZ templates from this repo instead of capz.

example expected usage: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml#L152-L161

These jobs are currently run with https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/scripts/ci-entrypoint.sh

/hold for testing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2025
@marosset
Updating run-capz-e2e.sh to run extra commands
5156618 
Signed-off-by: Mark Rossett <marosset@microsoft.com>
@marosset marosset force-pushed the run-capz-e2e-sh-run-extra-commands branch from 047b45b to 5156618 Compare December 5, 2025 21:27
@marosset
Copy link
Contributor Author

marosset commented Dec 5, 2025

/test ls

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2025

@marosset: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

/test pull-e2e-capz-validate-pr-templates

/test pull-e2e-capz-windows-2022-extension

/test pull-e2e-capz-windows-2022-extension-community-eks

/test pull-e2e-capz-windows-2022-extension-community-gke

/test pull-e2e-capz-windows-2022-extension-gmsa

/test pull-e2e-capz-windows-2022-staging-gallery

/test pull-e2e-capz-windows-2025-extension

/test pull-e2e-capz-windows-2025-staging-gallery

/test pull-e2e-run-capz-sh-windows-2022-hyperv

/test pull-kubernetes-e2enode-windows

/test pull-kubernetes-unit-windows

Use /test all to run the following jobs that were automatically triggered:

pull-e2e-capz-windows-2022-extension

pull-e2e-capz-windows-2025-extension
Details

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marosset
Copy link
Contributor Author

marosset commented Dec 5, 2025

/test pull-e2e-capz-windows-2022-azure-file

@marosset
Copy link
Contributor Author

marosset commented Dec 8, 2025

/test pull-e2e-capz-windows-2022-azure-ccm

1 similar comment
@marosset
Copy link
Contributor Author

marosset commented Dec 8, 2025

/test pull-e2e-capz-windows-2022-azure-ccm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2025

@marosset: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-capz-windows-2022-azure-file 5156618 link unknown /test pull-e2e-capz-windows-2022-azure-file
pull-e2e-capz-windows-2022-azure-ccm 5156618 link false /test pull-e2e-capz-windows-2022-azure-ccm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marosset
Copy link
Contributor Author

marosset commented Dec 9, 2025

@mboersma @zylxjtu - please take a look.
I have validated the functionality with kubernetes/test-infra#36047 and the test jobs (although they aren't passing, they are successfully running the extra bash code getting passed into run-capz-e2e.sh succesffully

@marosset marosset added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 9, 2025
mboersma
mboersma approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zylxjtu
zylxjtu reviewed Dec 11, 2025
View reviewed changes
capz/readme.md
Example usage from a Prow job:

```bash
./capz/run-capz-e2e.sh bash -c "cd ${GOPATH}/src/sigs.k8s.io/azuredisk-csi-driver && ./deploy/install-driver.sh master local,snapshot,enable-avset && make e2e-test"
Copy link
Contributor

@zylxjtu zylxjtu Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better/possible to separate the new added test cases into different file? but I do not have much context on the added test so just a rough idea

Copy link
Contributor Author

@marosset marosset Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean?
into a different markdown file?

@marosset
Copy link
Contributor Author

marosset commented Dec 11, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 181d35f into kubernetes-sigs:master Dec 11, 2025
8 of 10 checks passed
@marosset marosset deleted the run-capz-e2e-sh-run-extra-commands branch December 11, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zylxjtu zylxjtu zylxjtu left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jayunit100 jayunit100 Awaiting requested review from jayunit100

+1 more reviewer

@mboersma mboersma mboersma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marosset @k8s-ci-robot @mboersma @zylxjtu