Upgrade Buildroot to 2025.02.9 LTS for GCC 13+ compatibility #21997
Conversation
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @vtri950. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
|
Can one of the admins verify this patch? |
|
/ok-to-build-iso |
Makefile
Outdated
|
|
||
| INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1) | ||
| BUILDROOT_BRANCH ?= 2025.02 | ||
| BUILDROOT_BRANCH ?= 2025.08.2 |
There was a problem hiding this comment.
Any reason not to use 2025.08?
There was a problem hiding this comment.
2025.08.02 is the latest stable patch release
There was a problem hiding this comment.
Based on https://buildroot.org/download.html this version end of life is December 2025, so we have to update every month?
There was a problem hiding this comment.
Good point!
i have replaced it with the LTS version which contains the necessary fix.
|
failed iso build logs: Build failed with: @medyagh any clue why the build tries to add this remote? |
There was a problem hiding this comment.
@vtri950 please rebase on master. The gluster package is already removed in master for long time. This may also fix the build iso job.
After rebase we see:
% git show --stat
commit 113d9e35755e9b5a7aea6537aded9ef3a56605bd (HEAD -> upgrade-buildroot-gcc13)
Author: Vidit Tripathi <viditt14@gmail.com>
Date: Thu Nov 27 08:13:57 2025 +0530
Upgrade Buildroot to 2025.08.2 for GCC 13+ compatibility
Makefile | 2 +-
deploy/iso/minikube-iso/package/Config.in | 1 -
deploy/iso/minikube-iso/package/podman/Config.in | 11 -----------
deploy/iso/minikube-iso/package/podman/override.conf | 4 ----
deploy/iso/minikube-iso/package/podman/podman.conf | 1 -
deploy/iso/minikube-iso/package/podman/podman.hash | 7 -------
deploy/iso/minikube-iso/package/podman/podman.mk | 81 ---------------------------------------------------------------------------------
7 files changed, 1 insertion(+), 106 deletions(-)
the issue is here |
vtri950
force-pushed
the
upgrade-buildroot-gcc13
branch
from
0cbf9da to
8a09186
Compare
done |
|
/ok-to-build-iso |
|
/cc @afbjorklund |
vtri950
force-pushed
the
upgrade-buildroot-gcc13
branch
from
8a09186 to
6232705
Compare
vtri950
changed the title
Latest push change version to 2025.02.8
This was already in master for a while
Did you test latest push with with Fedora 43? Please update the PR message to reflect the actual change. If you are still testing it you can convert it to draft. |
|
/ok-to-build-iso |
|
Hi @vtri950, building a new ISO failed for Commit 8a09186 |
@vtri950 you can ignore this message, it is for the commit you replaced. We will get a new comment when the current build will complete. The build log will be here: |
|
It seems like this build issue is specific to Fedora*, but probably a good idea to update the OS minor anyway... * The default build environment uses Debian, currently bookworm (12, oldstable): support/docker/Dockerfile There was some earlier attempt to bump the Buildroot version, not sure what happened to that one? |
| source "$BR2_EXTERNAL_MINIKUBE_PATH/package/cni/Config.in" | ||
| source "$BR2_EXTERNAL_MINIKUBE_PATH/package/automount/Config.in" | ||
| source "$BR2_EXTERNAL_MINIKUBE_PATH/package/scheduled-stop/Config.in" | ||
| source "$BR2_EXTERNAL_MINIKUBE_PATH/package/podman/Config.in" |
There was a problem hiding this comment.
I don't think the podman package was added to Buildroot, until after 2025.02
Make sure that it is still enabled in the Buildroot config, and that it builds OK...
There was a problem hiding this comment.
commit ebbaac08e3f462bf023c12077f739ed1c0543eb2
Buildroot 2025.05
We did not attempt to resolve this issue yet. @vtri950 you can add this issue to this PR. |
i have updated the description |
|
This is something to watch out for in general, when replacing minikube packages with buildroot packages: -config BR2_PACKAGE_PODMAN
- bool "podman"
- default yThat is, the minikube packages were selected by default - while buildroot packages need to be selected:
Since minikube is already providing buildroot defconfig, having packages auto-select themselves was a mistake. It would have been nice to work closer with Buildroot upstream, and submit more packages for inclusion there. |
| [Socket] | ||
| SocketMode=0660 | ||
| SocketUser=root | ||
| SocketGroup=podman |
There was a problem hiding this comment.
You will need to keep this configuration, otherwise it will not be possible to reach podman socket
| @@ -1 +0,0 @@ | |||
| d /run/podman 0770 root podman | |||
There was a problem hiding this comment.
This as well, otherwise the directory containing the podman socket will be unreadable by the group
|
The default podman configuration can only be accessed by root, so it will not work for docker@minikube It would be possible to move this configuration outside the package though, and use systemd overrides.
|
nirs
left a comment
nirs
left a comment
There was a problem hiding this comment.
Testing shows that aarch64 iso fail on Fedora 43 and 42, so we cannot document it as working.
We can split the documentation update to a new PR or change it to document the issues on Fedora.
vtri950
force-pushed
the
upgrade-buildroot-gcc13
branch
from
ee66eb7 to
4e6ec0c
Compare
k8s-ci-robot
added
size/XS
i have removed the document part
can you open an issue with this finding? |
This comment has been minimized.
This comment has been minimized.
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund, nirs, vtri950 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
I created 2 issues:
|
k8s-ci-robot
added
the
needs-rebase
|
There is a new Buildroot 2025.02.9 released https://buildroot.org/news.html Consider also bumping the Linux version? See |
vtri950
force-pushed
the
upgrade-buildroot-gcc13
branch
from
4e6ec0c to
751b365
Compare
k8s-ci-robot
removed
the
needs-rebase
vtri950
changed the title
can we do the linux upgrade in a separate issue? |
This comment has been minimized.
This comment has been minimized.
You can separate it, the feedback was just that upstream includes a Linux upgrade with the rest of the OS release https://github.com/buildroot/buildroot/blob/2025.02.8/linux/linux.hash https://github.com/buildroot/buildroot/blob/2025.02.9/linux/linux.hash It is not automatic, because minikube is not using the "latest version" (6.12.x) but a "custom version" (6.6.x). https://github.com/buildroot/buildroot/blob/2025.02.x/linux/Config.in
|
|
We have another issue (#22031) for updating the kernel. Lets keep this change simple and merge it quickly. |
|
/ok-to-build-iso |
|
Hi @vtri950, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 driver with docker runtime DetailsTimes for minikube start: 38.5s 42.4s 42.2s 41.0s 43.8s Times for minikube ingress: 15.7s 15.8s 15.8s 15.7s 16.3s docker driver with docker runtime DetailsTimes for minikube start: 20.2s 23.7s 21.2s 22.8s 25.0s Times for minikube ingress: 10.6s 10.7s 9.6s 10.7s 10.7s docker driver with containerd runtime DetailsTimes for minikube start: 20.9s 19.2s 22.6s 21.2s 22.4s Times for minikube ingress: 21.1s 21.2s 20.2s 20.2s 20.1s |
|
@vtri950 after updating buildroot, did you run $ make iso-menuconfig-x86_64
$ git diff
$ git diff
diff --git a/deploy/iso/minikube-iso/configs/minikube_x86_64_defconfig b/deploy/iso/minikube-iso/configs/minikube_x86_64_defconfig
index 47fce0fa7..639a2fdf3 100644
--- a/deploy/iso/minikube-iso/configs/minikube_x86_64_defconfig
+++ b/deploy/iso/minikube-iso/configs/minikube_x86_64_defconfig
@@ -37,7 +37,6 @@ BR2_PACKAGE_XFSPROGS=y
BR2_PACKAGE_ACPID=y
BR2_PACKAGE_PARTED=y
BR2_PACKAGE_SYSSTAT=y
-BR2_PACKAGE_LUAJIT=y
BR2_PACKAGE_LZ4=y
BR2_PACKAGE_LZ4_PROGS=y
BR2_PACKAGE_CA_CERTIFICATES=y$ make iso-menuconfig-aarch64
$ git diff
diff --git a/deploy/iso/minikube-iso/configs/minikube_aarch64_defconfig b/deploy/iso/minikube-iso/configs/minikube_aarch64_defconfig
index 103782e79..f3cd6346e 100644
--- a/deploy/iso/minikube-iso/configs/minikube_aarch64_defconfig
+++ b/deploy/iso/minikube-iso/configs/minikube_aarch64_defconfig
@@ -40,7 +40,6 @@ BR2_PACKAGE_XFSPROGS=y
BR2_PACKAGE_ACPID=y
BR2_PACKAGE_PARTED=y
BR2_PACKAGE_SYSSTAT=y
-BR2_PACKAGE_LUAJIT=y
BR2_PACKAGE_LZ4=y
BR2_PACKAGE_LZ4_PROGS=y
BR2_PACKAGE_CA_CERTIFICATES=yMaybe luajit was removed from buildroot? It is important to run this after the update so we can continue to update the config using menuconfig. Otherwise we will find this change on the next time we update buildroot configuration. I'm running this on linux aarch64 vm - but usually we work on the iso configuration and build the iso on x86_64, so this may be a buildroot bug. @afbjorklund do you know why we see this change? I see that I run this on older buildroot 2025.02, testing again with 2025.02.9. Testing on the right buildroot show the same results, so this is not related to this change. I'll test again on x86_64. |
|
@vtri950: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Upgrade Buildroot to 2025.02.9 for GCC 13+ compatibility
Fixes #21967
Fixes #20993
Changes:
The newer Buildroot version includes updated package versions that are
compatible with modern GCC 13+ toolchains, eliminating build failures
on recent Linux distributions like Fedora 39+.
Tested on Fedora 43 with GCC 13.3.1.