Skip to content

Commit faa1c4a

Browse files
committed
Code cleanup, reduced duplication.
1 parent 8f0ad95 commit faa1c4a

28 files changed

+103
-146
lines changed

SimpleSudokuSolver.Tests/DefaultSolverTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using NUnit.Framework;
22
using SimpleSudokuSolver.Strategy;
3-
using System.Linq;
43

54
namespace SimpleSudokuSolver.Tests
65
{
@@ -38,7 +37,7 @@ public void DefaultSolverWithOnlyEliminationStrategies_CannotSolvePuzzle_Test()
3837
}
3938

4039
[Test]
41-
public void SolveSingleStepForSolvedPuzle_ReturnsNull_Test()
40+
public void SolveSingleStepForSolvedPuzzle_ReturnsNull_Test()
4241
{
4342
var defaultSolver = new DefaultSolver();
4443
var sudokuPuzzle = defaultSolver.Solve(_sudoku);

SimpleSudokuSolver.Tests/Model/RowTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public void ToStringTest()
3838
row.Cells[3] = new Cell(4);
3939
row.Cells[8] = new Cell(0);
4040
toString = row.ToString();
41-
Assert.That(toString, Is.EqualTo($"1 4 0"));
41+
Assert.That(toString, Is.EqualTo("1 4 0"));
4242
}
4343
}
4444
}

SimpleSudokuSolver.Tests/Strategy/HiddenPairTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class HiddenPairTests : BaseStrategyTest
1111
[Test]
1212
public void HiddenPairTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Hidden_Candidates
1717
{ 0,0,0,0,0,0,0,0,0 },
@@ -43,7 +43,7 @@ public void HiddenPairTest1()
4343
[Test]
4444
public void HiddenPairTest2()
4545
{
46-
var sudoku = new int[,]
46+
var sudoku = new [,]
4747
{
4848
// From: http://www.sudokuwiki.org/Hidden_Candidates
4949
{ 7,2,0,4,0,8,0,3,0 },

SimpleSudokuSolver.Tests/Strategy/HiddenQuadTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class HiddenQuadTests : BaseStrategyTest
1111
[Test]
1212
public void HiddenQuadTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Hidden_Candidates
1717
{ 6,5,0,0,8,7,0,2,4 },
@@ -45,7 +45,7 @@ public void HiddenQuadTest1()
4545
[Test]
4646
public void HiddenQuadTest2()
4747
{
48-
var sudoku = new int[,]
48+
var sudoku = new [,]
4949
{
5050
// From: http://www.sudokuwiki.org/Hidden_Candidates
5151
{ 9,0,1,5,0,0,0,4,6 },

SimpleSudokuSolver.Tests/Strategy/HiddenSingleTests.cs

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class HiddenSingleTests : BaseStrategyTest
1111
[Test]
1212
public void HiddenSingleTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Getting_Started
1717
{ 2,0,0,0,7,0,0,3,8 },
@@ -34,7 +34,7 @@ public void HiddenSingleTest1()
3434
[Test]
3535
public void HiddenSingleTest2()
3636
{
37-
var sudoku = new int[,]
37+
var sudoku = new [,]
3838
{
3939
// From: https://sudoku9x9.com/hidden_single.html
4040
{ 0,0,0,0,0,0,0,0,0 },
@@ -53,27 +53,5 @@ public void HiddenSingleTest2()
5353

5454
Assert.That(sudokuPuzzle.Cells[4, 1].Value, Is.EqualTo(2));
5555
}
56-
57-
[Test]
58-
public void HiddenSingleTest3()
59-
{
60-
var sudoku = new int[,]
61-
{
62-
{ 0,0,0,0,3,0,0,8,6 },
63-
{ 0,0,0,0,2,0,0,4,0 },
64-
{ 0,0,0,0,7,8,5,2,0 },
65-
{ 3,7,1,8,5,6,2,9,4 },
66-
{ 9,0,0,1,4,2,3,7,5 },
67-
{ 4,0,0,3,9,7,6,1,8 },
68-
{ 2,0,0,7,0,3,8,5,9 },
69-
{ 0,3,9,2,0,5,4,6,7 },
70-
{ 7,0,0,9,0,4,1,3,2 }
71-
};
72-
73-
var sudokuPuzzle = new SudokuPuzzle(sudoku);
74-
SolveUsingStrategy(sudokuPuzzle, _strategy);
75-
76-
Assert.That(sudokuPuzzle.Cells[2, 1].Value, Is.EqualTo(9));
77-
}
7856
}
7957
}

SimpleSudokuSolver.Tests/Strategy/HiddenTripleTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class HiddenTripleTests : BaseStrategyTest
1111
[Test]
1212
public void HiddenTripleTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Hidden_Candidates
1717
{ 0,0,0,0,0,1,0,3,0 },

SimpleSudokuSolver.Tests/Strategy/LockedCandidatesPointingTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class LockedCandidatesPointingTests : BaseStrategyTest
1111
[Test]
1212
public void LockedCandidatesPointingInColumnTest()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: https://sudoku9x9.com/locked_candidates.html
1717
{ 0,1,2,0,0,0,0,0,0 },
@@ -40,7 +40,7 @@ public void LockedCandidatesPointingInColumnTest()
4040
public void LockedCandidatesPointingInRowTest()
4141
{
4242
// From: https://sudoku9x9.com/locked_candidates.html, transposed
43-
var sudoku = new int[,]
43+
var sudoku = new [,]
4444
{
4545
{ 0,0,0,0,0,0,0,0,0 },
4646
{ 1,0,5,0,0,0,0,0,0 },
@@ -67,7 +67,7 @@ public void LockedCandidatesPointingInRowTest()
6767
[Test]
6868
public void LockedCandidatesPointingTest1()
6969
{
70-
var sudoku = new int[,]
70+
var sudoku = new [,]
7171
{
7272
// From: http://www.sudokuwiki.org/Intersection_Removal
7373
{ 0,1,7,9,0,3,6,0,0 },
@@ -97,7 +97,7 @@ public void LockedCandidatesPointingTest1()
9797
[Test]
9898
public void LockedCandidatesPointingTest2()
9999
{
100-
var sudoku = new int[,]
100+
var sudoku = new [,]
101101
{
102102
// From: http://www.sudokuwiki.org/Intersection_Removal
103103
{ 0,3,2,0,0,6,1,0,0 },
@@ -151,7 +151,7 @@ public void LockedCandidatesPointingTest2()
151151
[Test]
152152
public void LockedCandidatesPointingTest3()
153153
{
154-
var sudoku = new int[,]
154+
var sudoku = new [,]
155155
{
156156
// From: http://www.sudokuwiki.org/Intersection_Removal
157157
{ 9,3,0,0,5,0,0,0,0 },

SimpleSudokuSolver.Tests/Strategy/NakedPairTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class NakedPairTests : BaseStrategyTest
1212
public void NakedPairInRowTest()
1313
{
1414
// From: https://sudoku9x9.com/naked_pair.html
15-
var sudoku = new int[,]
15+
var sudoku = new [,]
1616
{
1717
{ 9,0,0,4,0,0,1,0,0 },
1818
{ 0,5,6,0,0,0,0,0,0 },
@@ -37,7 +37,7 @@ public void NakedPairInRowTest()
3737
public void NakedPairInColumnTest()
3838
{
3939
// From: https://sudoku9x9.com/naked_pair.html, transposed
40-
var sudoku = new int[,]
40+
var sudoku = new [,]
4141
{
4242
{ 9,0,0,0,0,0,0,0,0 },
4343
{ 0,5,7,0,0,0,0,0,0 },
@@ -61,7 +61,7 @@ public void NakedPairInColumnTest()
6161
[Test]
6262
public void NakedPairTest1()
6363
{
64-
var sudoku = new int[,]
64+
var sudoku = new [,]
6565
{
6666
// From: http://www.sudokuwiki.org/Naked_Candidates
6767
{ 4,0,0,0,0,0,9,3,8 },
@@ -92,7 +92,7 @@ public void NakedPairTest1()
9292
[Test]
9393
public void NakedPairTest2()
9494
{
95-
var sudoku = new int[,]
95+
var sudoku = new [,]
9696
{
9797
// From: http://www.sudokuwiki.org/Naked_Candidates
9898
{ 0,8,0,0,9,0,0,3,0 },

SimpleSudokuSolver.Tests/Strategy/NakedQuadTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class NakedQuadTests : BaseStrategyTest
1111
[Test]
1212
public void NakedQuadTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Naked_Candidates
1717
// Contains one naked quad in block, and after that, one naked quad in row
@@ -41,7 +41,7 @@ public void NakedQuadTest1()
4141
[Test]
4242
public void NakedQuadTest2()
4343
{
44-
var sudoku = new int[,]
44+
var sudoku = new [,]
4545
{
4646
// From: http://www.manifestmaster.com/jetsudoku/nakedQuad.html
4747
// Naked quad in column - must first use LockedCandidatesPointing to eliminate some candidates

SimpleSudokuSolver.Tests/Strategy/NakedSingleTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class NakedSingleTests : BaseStrategyTest
1111
[Test]
1212
public void NakedSingleTest1()
1313
{
14-
var sudoku = new int[,]
14+
var sudoku = new [,]
1515
{
1616
// From: http://www.sudokuwiki.org/Getting_Started
1717
{ 2,4,6,0,7,0,0,3,8 },
@@ -34,7 +34,7 @@ public void NakedSingleTest1()
3434
[Test]
3535
public void NakedSingleTest2()
3636
{
37-
var sudoku = new int[,]
37+
var sudoku = new [,]
3838
{
3939
// From: https://sudoku9x9.com/naked_single.html
4040
{ 0,0,0,1,0,2,0,0,0 },

0 commit comments

Comments
 (0)