-
Notifications
You must be signed in to change notification settings - Fork 17
feat: nodejs24 #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: nodejs24 #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Lines 61 to 65 in 714dc23
| "files": [ | |
| "dist/**/*", | |
| "index.js", | |
| "index.d.ts", | |
| "src/**/*.js", |
package.json now sets main to out/index.js, but the files whitelist still only exports dist/**/*, index.js, and src/**/*.js (lines 61‑65), so npm pack/npm publish will drop the newly built out directory. Any install from the registry will lack out/index.js, and require('kuzzle-sdk') will fail with “Cannot find module '…/out/index.js'”. Add the out/** output (and declarations) to the files list to keep the published package loadable.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Overview