ACPT-1688: Fix Static Tests failures on Application-Server branch 2

Author: yaroslavGoncharuk

app/code/Magento/CatalogGraphQl/DataProvider/Product/RequestDataBuilder.php

@@ -17,24 +17,29 @@ class RequestDataBuilder implements ResetAfterRequestInterface
      */
     private array $data;
 
+    /**
+     * Constructor
+     *
+     * @return void
+     */
     public function __construct()
     {
         $this->_resetState();
     }
 
     /**
-     * Sets the data
+     * Sets request data
      *
-     * @param $data
+     * @param array $data
      * @return void
      */
-    public function setData($data): void
+    public function setData(array $data): void
     {
         $this->data = $data;
     }
 
     /**
-     * Gets the data
+     * Gets request data
      *
      * @param string $key
      * @return mixed|null

app/code/Magento/CatalogGraphQl/DataProvider/Product/SearchCriteriaBuilder.php

@@ -70,7 +70,7 @@ class SearchCriteriaBuilder
     private SearchConfig $searchConfig;
 
     /**
-     * @var RequestDataBuilder|mixed 
+     * @var RequestDataBuilder|mixed
      */
     private RequestDataBuilder $localData;
 

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/Price/Provider.php

@@ -36,14 +36,21 @@ class Provider implements ProviderInterface, ResetAfterRequestInterface
 
     /**
      * @var array|array[]
+     *
+     * @SuppressWarnings(PHPCS)
      */
     private readonly array $minimalPriceConstructed;
 
     /**
      * @var array|array[]
+     *
+     * @SuppressWarnings(PHPCS)
      */
     private readonly array $maximalPriceConstructed;
 
+    /**
+     * Constructor
+     */
     public function __construct()
     {
         $this->minimalPriceConstructed = $this->minimalPrice;

dev/tests/integration/testsuite/Magento/GraphQl/App/State/GraphQlStateDiff.php

@@ -34,15 +34,30 @@ class GraphQlStateDiff
 {
     private const CONTENT_TYPE = 'application/json';
 
-    /** @var ObjectManagerInterface */
+    /**
+     * @var ObjectManagerInterface
+     *
+     * @SuppressWarnings(PHPCS)
+     */
     private readonly ObjectManagerInterface $objectManagerBeforeTest;
 
-    /** @var ObjectManager */
+    /**
+     * @var ObjectManager
+     *
+     * @SuppressWarnings(PHPCS)
+     */
     private readonly ObjectManager $objectManagerForTest;
 
-    /** @var Comparator */
+    /**
+     * @var Comparator
+     *
+     * @SuppressWarnings(PHPCS)
+     */
     private readonly Comparator $comparator;
 
+    /**
+     * Constructor
+     */
     public function __construct()
     {
         $this->objectManagerBeforeTest = Bootstrap::getObjectManager();
@@ -55,6 +70,8 @@ public function __construct()
     }
 
     /**
+     * Gets test object manager
+     *
      * @return ObjectManager
      */
     public function getTestObjectManager()
@@ -73,6 +90,8 @@ public function tearDown(): void
     }
 
     /**
+     * Tests state
+     *
      * @param string $query
      * @param array $variables
      * @param array $variables2
@@ -133,6 +152,8 @@ public function testState(
     }
 
     /**
+     * Makes request
+     *
      * @param string $query
      * @param string $operationName
      * @param array $authInfo
@@ -208,6 +229,8 @@ private function doRequest(string $query, array $authInfo)
     }
 
     /**
+     * Removes coupon from cart
+     *
      * @param array $variables
      * @return void
      * @throws NoSuchEntityException
@@ -221,6 +244,8 @@ private function removeCouponFromCart(array $variables)
     }
 
     /**
+     * Reactivates cart
+     *
      * @param string $cartId
      * @return void
      * @throws NoSuchEntityException
@@ -235,6 +260,8 @@ private function reactivateCart(string $cartId)
     }
 
     /**
+     * Gets cart id
+     *
      * @param string $cartId
      * @return int
      * @throws NoSuchEntityException
@@ -246,6 +273,8 @@ private function getCartId(string $cartId)
     }
 
     /**
+     * Gets cart id hash
+     *
      * @param string $cartId
      * @return string
      * @throws NoSuchEntityException

lib/internal/Magento/Framework/App/Cache/State.php

@@ -20,7 +20,7 @@ class State implements StateInterface, ResetAfterRequestInterface
     /**
      * Disallow cache
      */
-    const PARAM_BAN_CACHE = 'global_ban_use_cache';
+    public const PARAM_BAN_CACHE = 'global_ban_use_cache';
 
     /**
      * Deployment config key
@@ -38,20 +38,24 @@ class State implements StateInterface, ResetAfterRequestInterface
      * Deployment configuration storage writer
      *
      * @var Writer
+     *
+     * @SuppressWarnings(PHPCS)
      */
     private readonly Writer $writer;
 
     /**
      * Associative array of cache type codes and their statuses (enabled/disabled)
      *
      * @var array|null
+     * @SuppressWarnings(PHPCS)
      */
     private ?array $statuses = null;
 
     /**
      * Whether all cache types are forced to be disabled
      *
      * @var bool
+     * @SuppressWarnings(PHPCS)
      */
     private readonly bool $banAll;
 
@@ -125,7 +129,7 @@ private function load(): void
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function _resetState(): void
     {

lib/internal/Magento/Framework/TestFramework/ApplicationStateComparator/Collector.php

@@ -89,6 +89,7 @@ function ($element) use (
      * @param ShouldResetState $shouldResetState
      * @return CollectedObject[]
      * @throws \Exception
+     * @SuppressWarnings(PHPCS)
      */
     public function getSharedObjects(ShouldResetState $shouldResetState): array
     {
@@ -128,6 +129,7 @@ public function getSharedObjects(ShouldResetState $shouldResetState): array
      *
      * @return CollectedObjectConstructedAndCurrent[]
      * @throws \Exception
+     * @SuppressWarnings(PHPCS)
      */
     public function getPropertiesConstructedAndCurrent(): array
     {

lib/internal/Magento/Framework/TestFramework/ApplicationStateComparator/Comparator.php

@@ -232,6 +232,7 @@ private function formatValue($value): mixed
      * @return array
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @throws \Exception
+     * @SuppressWarnings(PHPCS)
      */
     public function checkValues(mixed $before, mixed $after, array $skipList): array
     {

lib/internal/Magento/Framework/TestFramework/ApplicationStateComparator/ObjectManager.php

@@ -20,6 +20,7 @@ class ObjectManager extends TestFrameworkObjectManager implements ObjectManagerI
      * Constructs this instance by copying test framework's ObjectManager
      *
      * @param TestFrameworkObjectManager $testFrameworkObjectManager
+     * @SuppressWarnings(PHPCS)
      */
     private array $bootstrappedObjects = [
         // Note: These are after $objectManager = $this->_factory->create($overriddenParams);