Skip to content

Commit cfa7719

Browse files
ACQE-8858: Verify that The store that was requested should be visible on credit memo grid page in admin
- Fixed static checks to reduce Coupling Betwee Objects
1 parent 0f22b0d commit cfa7719

File tree

1 file changed

+12
-24
lines changed

1 file changed

+12
-24
lines changed

dev/tests/integration/testsuite/Magento/Sales/Model/StoreWithNumericNameCreditmemoWorkflowTest.php

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,7 @@
1313
use Magento\Sales\Api\Data\CreditmemoInterface;
1414
use Magento\Sales\Api\Data\OrderInterface;
1515
use Magento\TestFramework\Helper\Bootstrap;
16-
use Magento\Catalog\Test\Fixture\Product as ProductFixture;
17-
use Magento\Store\Test\Fixture\Website as WebsiteFixture;
18-
use Magento\Store\Test\Fixture\Group as StoreGroupFixture;
19-
use Magento\Store\Test\Fixture\Store as StoreFixture;
2016
use Magento\Store\Api\Data\StoreInterface;
21-
use Magento\Customer\Test\Fixture\Customer as CustomerFixture;
22-
use Magento\Checkout\Test\Fixture\SetBillingAddress as SetBillingAddressFixture;
23-
use Magento\Checkout\Test\Fixture\SetShippingAddress as SetShippingAddressFixture;
24-
use Magento\Checkout\Test\Fixture\SetDeliveryMethod as SetDeliveryMethodFixture;
25-
use Magento\Checkout\Test\Fixture\SetPaymentMethod as SetPaymentMethodFixture;
26-
use Magento\Checkout\Test\Fixture\PlaceOrder as PlaceOrderFixture;
27-
use Magento\Sales\Test\Fixture\Invoice as InvoiceFixture;
28-
use Magento\Sales\Test\Fixture\Creditmemo as CreditmemoFixture;
2917
use Magento\TestFramework\Fixture\DataFixture;
3018
use Magento\TestFramework\Fixture\DataFixtureStorageManager;
3119

@@ -69,14 +57,14 @@ protected function setUp(): void
6957
* @return void
7058
*/
7159
#[
72-
DataFixture(WebsiteFixture::class, ['code' => 'test_website', 'name' => '123test Website'], 'test_website'),
60+
DataFixture('Magento\Store\Test\Fixture\Website', ['code' => 'test_website', 'name' => '123test Website'], 'test_website'),
7361
DataFixture(
74-
StoreGroupFixture::class,
62+
'Magento\Store\Test\Fixture\Group',
7563
['code' => 'test_group', 'name' => '123test Store Group', 'website_id' => '$test_website.id$'],
7664
'test_group'
7765
),
7866
DataFixture(
79-
StoreFixture::class,
67+
'Magento\Store\Test\Fixture\Store',
8068
[
8169
'code' => 'test_store',
8270
'name' => '123test Store View',
@@ -86,12 +74,12 @@ protected function setUp(): void
8674
'test_store'
8775
),
8876
DataFixture(
89-
ProductFixture::class,
77+
'Magento\Catalog\Test\Fixture\Product',
9078
['sku' => 'simple', 'price' => 10, 'website_ids' => [1, '$test_website.id$']],
9179
'product'
9280
),
9381
DataFixture(
94-
CustomerFixture::class,
82+
'Magento\Customer\Test\Fixture\Customer',
9583
['email' => 'customer@123test.com', 'website_id' => '$test_website.id$'],
9684
'customer'
9785
),
@@ -119,27 +107,27 @@ public function testCompleteWorkflowWithNumericStoreNames(): void
119107
$cartRepository->save($cart);
120108

121109
// Step 3: Use fixtures for checkout process
122-
$billingAddressFixture = $this->objectManager->create(SetBillingAddressFixture::class);
110+
$billingAddressFixture = $this->objectManager->create('Magento\Checkout\Test\Fixture\SetBillingAddress');
123111
$billingAddressFixture->apply(['cart_id' => $cart->getId()]);
124112

125-
$shippingAddressFixture = $this->objectManager->create(SetShippingAddressFixture::class);
113+
$shippingAddressFixture = $this->objectManager->create('Magento\Checkout\Test\Fixture\SetShippingAddress');
126114
$shippingAddressFixture->apply(['cart_id' => $cart->getId()]);
127115

128-
$deliveryMethodFixture = $this->objectManager->create(SetDeliveryMethodFixture::class);
116+
$deliveryMethodFixture = $this->objectManager->create('Magento\Checkout\Test\Fixture\SetDeliveryMethod');
129117
$deliveryMethodFixture->apply(
130118
['cart_id' => $cart->getId(), 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']
131119
);
132120

133-
$paymentMethodFixture = $this->objectManager->create(SetPaymentMethodFixture::class);
121+
$paymentMethodFixture = $this->objectManager->create('Magento\Checkout\Test\Fixture\SetPaymentMethod');
134122
$paymentMethodFixture->apply(['cart_id' => $cart->getId()]);
135123

136-
$placeOrderFixture = $this->objectManager->create(PlaceOrderFixture::class);
124+
$placeOrderFixture = $this->objectManager->create('Magento\Checkout\Test\Fixture\PlaceOrder');
137125
$order = $placeOrderFixture->apply(['cart_id' => $cart->getId()]);
138126

139-
$invoiceFixture = $this->objectManager->create(InvoiceFixture::class);
127+
$invoiceFixture = $this->objectManager->create('Magento\Sales\Test\Fixture\Invoice');
140128
$invoiceFixture->apply(['order_id' => $order->getId()]);
141129

142-
$creditmemoFixture = $this->objectManager->create(CreditmemoFixture::class);
130+
$creditmemoFixture = $this->objectManager->create('Magento\Sales\Test\Fixture\Creditmemo');
143131
$creditmemo = $creditmemoFixture->apply([
144132
'order_id' => $order->getId(),
145133
'items' => [['qty' => 1, 'product_id' => $product->getId()]]

0 commit comments

Comments
 (0)