Room: Add a method to set your own user's display name within a room #5981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/ffi-room-nick
branch
from
b0c1a9a to
39ff559
Compare
For e.g. the /myroomnick slash command.
pixlwave
force-pushed
the
doug/ffi-room-nick
branch
from
39ff559 to
65e19c9
Compare
CodSpeed Performance ReportMerging #5981 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.01%
==========================================
Files 364 364
Lines 104341 104359 +18
Branches 104341 104359 +18
==========================================
+ Hits 92438 92451 +13
- Misses 7537 7542 +5
Partials 4366 4366 ☔ View full report in Codecov by Sentry. |
zecakeh
reviewed
Dec 20, 2025
Comment on lines
+1124
to
+1130
| let Some(member_event) = member_event else { | ||
| return Err(Error::InsufficientData); | ||
| }; | ||
|
|
||
| let RawSyncOrStrippedState::Sync(raw_event) = member_event else { | ||
| return Err(Error::InsufficientData); | ||
| }; |
Collaborator
There was a problem hiding this comment.
These two checks can be collapsed into a single one.
|
|
||
| let event = raw_event.deserialize()?; | ||
|
|
||
| let SyncStateEvent::Original(ev) = event else { |
Collaborator
There was a problem hiding this comment.
Having a redacted event shouldn't prevent from changing the display name. We can create a new RoomMemberEventContent with the same membership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wanted to add this for ages now… This PR lets clients implement e.g. the
/myroomnickslash command.🎄🎁