Unify and rename struct WithOffset
#1334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
added
the
low priority
kkysen
reviewed
Aug 13, 2024
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
I'm not sure if Cursor is a better name than WithOffset. WithOffset isn't a smooth but it's descriptive, because it just adds an offset to anything (which could even be ()). And it matches the similar WithStride, which just adds a stride to anything.
We can unify the existing Cursor with WithOffset, though. That part seems good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.