Skip to content

Fix glob package vulnerability #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemanjarogic merged 12 commits into from
Dec 10, 2025
Merged

Fix glob package vulnerability #1138

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1f339d6
Fix glob package vulnerability
nemanjarogic Dec 2, 2025
0e0f10a
Fix build
nemanjarogic Dec 3, 2025
e950a7e
Upgrade version and partially fix tests
nemanjarogic Dec 4, 2025
01da704
Fix powershell test
nemanjarogic Dec 4, 2025
34b4e75
Fix node tests
nemanjarogic Dec 4, 2025
de4ea7d
Minimize changes
nemanjarogic Dec 4, 2025
8256c1f
Update typescript version
nemanjarogic Dec 4, 2025
3e5befb
Align es versions
nemanjarogic Dec 4, 2025
37d5578
Minimize changes and revert from migration to es2020
nemanjarogic Dec 5, 2025
9104892
Remove unnecessary changes
nemanjarogic Dec 5, 2025
e53e3ed
Revert check
nemanjarogic Dec 8, 2025
52ee866
Revert changes in powershell's psRunner
nemanjarogic Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node/docs/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES5",
"target": "es2020",
"module": "commonjs",
"declaration": false,
"moduleResolution": "node"
Expand Down
10 changes: 6 additions & 4 deletions node/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export function _loc(key: string, ...param: any[]): string {
* @param name name of the variable to get
* @returns string
*/
export function _getVariable(name: string): string | undefined {
export function _getVariable(name: string, skipDebug: boolean = false): string | undefined {
let varval: string | undefined;

// get the metadata
Expand All @@ -279,7 +279,9 @@ export function _getVariable(name: string): string | undefined {
}
}

_debug(name + '=' + varval);
if (!skipDebug) {
_debug(name + '=' + varval);
}
return varval;
}

Expand Down Expand Up @@ -344,8 +346,8 @@ export function _error(
);
}

const debugMode = _getVariable('system.debug')?.toLowerCase() === 'true';
const shouldCheckDebugMode = _getVariable('DistributedTask.Tasks.Node.SkipDebugLogsWhenDebugModeOff')?.toLowerCase() === 'true';
const debugMode = _getVariable('system.debug', true)?.toLowerCase() === 'true';
const shouldCheckDebugMode = _getVariable('DistributedTask.Tasks.Node.SkipDebugLogsWhenDebugModeOff', true)?.toLowerCase() === 'true';

export function _debug(message: string): void {
if (
Expand Down
5 changes: 3 additions & 2 deletions node/make.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ target.build = function() {
cp(rp('ThirdPartyNotice.txt'), buildPath);
cp('-Rf', rp('Strings'), buildPath);
// just a bootstrap file to avoid /// in final js and .d.ts file
rm(path.join(buildPath, 'index.*'));
// Use force flag so build doesn't fail if files don't exist
rm('-f', path.join(buildPath, 'index.*'));
}

target.test = async function() {
Expand All @@ -44,7 +45,7 @@ target.test = async function() {
cp('-Rf', rp('test/fakeTasks'), testPath);
process.env['TASKLIB_INPROC_UNITS'] = '1'; // export task-lib internals for internal unit testing
set('+e'); // Don't throw an exception when tests fail
run('mocha ' + testPath);
run('npx mocha ' + testPath);
}

target.loc = function() {
Expand Down
Loading
Loading