Fix nil pointer dereference in completion at property start after JSDoc #2259
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting completions at the beginning of a property name preceded by JSDoc caused a nil pointer panic when accessing
contextToken.Kind.Root Cause
Variable shadowing in
getRelevantTokens: Used:=instead of=, creating a local variable that shadowed the return parameter, causingcontextTokento return nil.Missing nil guards in
tryGetClassLikeCompletionSymbols:tryGetObjectTypeDeclarationCompletionContainercan return a non-nil declaration whencontextTokenis nil (e.g., when location is an identifier in a class body).Changes
getRelevantTokens(line 2753)contextToken.KindandcontextToken.ParentintryGetClassLikeCompletionSymbols(lines 1447, 1461, 1464, 1471)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.