Skip to content

Get merged symbol after resolving indirection alias #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 2 commits into from
Dec 7, 2025
+5 −23
Merged

Get merged symbol after resolving indirection alias #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f0ef46
Get merged symbol when resolving indirection alias
ahejlsberg Dec 7, 2025
94aecaa
Accept new baselines
ahejlsberg Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15800,7 +15800,7 @@ func (c *Checker) resolveAlias(symbol *ast.Symbol) *ast.Symbol {
}

func (c *Checker) resolveIndirectionAlias(source *ast.Symbol, target *ast.Symbol) *ast.Symbol {
result := c.resolveAlias(target)
result := c.getMergedSymbol(c.resolveAlias(target))
if targetLinks := c.aliasSymbolLinks.Get(target); targetLinks.typeOnlyDeclaration != nil {
if sourceLinks := c.aliasSymbolLinks.Get(source); sourceLinks.typeOnlyDeclaration == nil {
sourceLinks.typeOnlyDeclaration = targetLinks.typeOnlyDeclaration
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/conformance/umd-augmentation-3.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var t = p.x;

=== node_modules/math2d/index.d.ts ===
export as namespace Math2d;
>Math2d : typeof import("node_modules/math2d/index")
>Math2d : typeof import("node_modules/math2d/index.d.ts")

export = M2D;
>M2D : typeof import("node_modules/math2d/index.d.ts")
Expand Down
11 changes: 1 addition & 10 deletions testdata/baselines/reference/submodule/conformance/umd-augmentation-3.types.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,7 @@

var t = p.x;
>t : number
@@= skipped -12, +12 lines =@@

=== node_modules/math2d/index.d.ts ===
export as namespace Math2d;
->Math2d : typeof import("node_modules/math2d/index.d.ts")
+>Math2d : typeof import("node_modules/math2d/index")

export = M2D;
>M2D : typeof import("node_modules/math2d/index.d.ts")
@@= skipped -53, +53 lines =@@
@@= skipped -65, +65 lines =@@
// Add a method to the class
interface Vector {
reverse(): Math2d.Point;
Expand Down
2 changes: 1 addition & 1 deletion testdata/baselines/reference/submodule/conformance/umd-augmentation-4.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var t = p.x;

=== node_modules/math2d/index.d.ts ===
export as namespace Math2d;
>Math2d : typeof import("node_modules/math2d/index")
>Math2d : typeof import("node_modules/math2d/index.d.ts")

export = M2D;
>M2D : typeof import("node_modules/math2d/index.d.ts")
Expand Down
11 changes: 1 addition & 10 deletions testdata/baselines/reference/submodule/conformance/umd-augmentation-4.types.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
--- old.umd-augmentation-4.types
+++ new.umd-augmentation-4.types
@@= skipped -45, +45 lines =@@

=== node_modules/math2d/index.d.ts ===
export as namespace Math2d;
->Math2d : typeof import("node_modules/math2d/index.d.ts")
+>Math2d : typeof import("node_modules/math2d/index")

export = M2D;
>M2D : typeof import("node_modules/math2d/index.d.ts")
@@= skipped -53, +53 lines =@@
@@= skipped -98, +98 lines =@@
// Add a method to the class
interface Vector {
reverse(): Math2d.Point;
Expand Down