Skip to content

Add gear icon to Description label that opens pullRequestDescription setting #8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexr00 merged 10 commits into from
Dec 18, 2025
+13 −1
Merged

Add gear icon to Description label that opens pullRequestDescription setting #8248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e838393
Initial plan
Copilot Dec 9, 2025
abfdbb2
Initial plan for adding gear icon to Description label
Copilot Dec 9, 2025
30c9414
Add gear icon to Description label that opens pull request descriptio…
Copilot Dec 9, 2025
4b9147b
Fix keyboard accessibility - use event.type instead of 'in' operator
Copilot Dec 9, 2025
2ac1bf2
Use button element instead of anchor and improve keyboard handling
Copilot Dec 9, 2025
69de40f
Add aria-label and refactor event handler for better code quality
Copilot Dec 9, 2025
cea7a72
clean up
alexr00 Dec 18, 2025
dae7922
tab
alexr00 Dec 18, 2025
27ea979
Merge remote-tracking branch 'origin/main' into copilot/add-gear-icon…
alexr00 Dec 18, 2025
a98868f
Undo css
alexr00 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/github/createPRViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,10 @@ export abstract class BaseCreatePullRequestViewProvider<T extends BasePullReques
return this._replyMessage(message, undefined);
}

private async openDescriptionSettings(): Promise<void> {
return vscode.commands.executeCommand('workbench.action.openSettings', 'githubPullRequests.pullRequestDescription');
}

protected override async _onDidReceiveMessage(message: IRequestMessage<any>) {
const result = await super._onDidReceiveMessage(message);
if (result !== this.MESSAGE_UNHANDLED) {
Expand Down Expand Up @@ -569,6 +573,9 @@ export abstract class BaseCreatePullRequestViewProvider<T extends BasePullReques
case 'pr.removeLabel':
return this.removeLabel(message);

case 'pr.openDescriptionSettings':
return this.openDescriptionSettings();

default:
return this.MESSAGE_UNHANDLED;
}
Expand Down
7 changes: 6 additions & 1 deletion webviews/createPullRequestViewNew/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import PullRequestContextNew from '../common/createContextNew';
import { ErrorBoundary } from '../common/errorBoundary';
import { LabelCreate } from '../common/label';
import { ContextDropdown } from '../components/contextDropdown';
import { accountIcon, feedbackIcon, gitCompareIcon, milestoneIcon, notebookTemplate, prMergeIcon, projectIcon, sparkleIcon, stopCircleIcon, tagIcon } from '../components/icon';
import { accountIcon, feedbackIcon, gitCompareIcon, milestoneIcon, notebookTemplate, prMergeIcon, projectIcon, settingsIcon, sparkleIcon, stopCircleIcon, tagIcon } from '../components/icon';
import { Avatar } from '../components/user';

type CreateMethod = 'create-draft' | 'create' | 'create-automerge-squash' | 'create-automerge-rebase' | 'create-automerge-merge';
Expand Down Expand Up @@ -173,6 +173,10 @@ export function main() {
}
}

function openDescriptionSettings(_event: React.MouseEvent | React.KeyboardEvent): void {
ctx.postMessage({ command: 'pr.openDescriptionSettings' });
}

async function generateTitle(useCopilot?: boolean) {
setGeneratingTitle(true);
await ctx.generateTitle(!!useCopilot);
Expand Down Expand Up @@ -337,6 +341,7 @@ export function main() {
<label htmlFor='description' className='input-title'>Description</label>
{ctx.createParams.usingTemplate ?
<a title='Change template' className={`title-action icon-button${isBusy || !ctx.initialized ? ' disabled' : ''}`} onClick={() => changeTemplate()} tabIndex={0}>{notebookTemplate}</a> : null}
<a role='button' title='Open pull request description settings' aria-label='Open pull request description settings' className='icon-button' onClick={openDescriptionSettings} tabIndex={0}>{settingsIcon}</a>
</div>
<div className='group-description'>
<textarea
Expand Down