InlineEditsView: remove redeclaration of textModel #281501
Open
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant code by eliminating an unnecessary re-read and null-check of the text model. The textModel variable is already declared and validated at the beginning of the _uiState derived callback (line 309-310), and nothing between that check and its later usage could invalidate it. The removed code (re-reading this._editorObs.model.read(reader) as tm) was functionally identical but added unnecessary complexity.
- Removes redundant re-declaration and null-check of
textModelvariable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that tm variable is redundant, because textModel is already read above. I don't see anything that can change it before it is reloaded, am I missing something?
If not, I think it worth it to remove redeclaration to simplify code.