chore: update node requirement in the monorepo to match electron version #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
no-title-validation
Collaborator
Author
|
Thought the issue went away, but nope, actually the same thing stil EDIT: okay, found a way around it, it's a workaround, but we can probably live with this for now and means that we're not blocked on Node.js update if needed |
…ption to make sure that ts-node is the only one parsing ts files See https://github.com/mongodb-js/compass/pull/7339\#issuecomment-3337995893 for what exactly is happening
Collaborator
Author
|
@Anemy if you have a moment as a first reponder this week it would probably be good to merge just to make sure that we're not blocked on Node.js updates because of this quirk caused by |
addaleax
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled on this draft that was bumping Node.js to the version matching our electron version that I completely lost track of. The electron version drifted some more, so I'm reopening it. I found a way to work around the issue that I described in #7339 (comment) by explicitly disabling the node option for experimental strip types behavior (also noticed that @kmruiz is doing the same thing in mongodb-js/mongosh#2586, so I guess we ran into this already in mongosh too). This should be considered just a temporary workaround though as on top of just breaking the tests it just highlights the issue that we're not ready to go proper esm in the repo, so I opened a ticket to follow-up with a proper solution to this.
I'm probably not going to see the CI finish before I'm OOO for the holidays, but if it's green, it would be good to merge this one as this will probably become a blocker anyway at any moment if we will need to update Node.js version for any other reason