feat: Adds mongodbatlas_log_integration data source
#3978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
APIx bot: a message has been sent to Docs Slack channel |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new data source mongodbatlas_log_integration to enable read-only access to log integration configurations. The implementation uses autogenerated code based on the existing resource schema, and enhances the Makefile to automatically register data sources in the provider.
- Adds
mongodbatlas_log_integrationdata source with autogenerated schema and implementation - Updates Makefile to automatically add singular data sources to the provider during
make enable-autogen - Adds acceptance tests for the new data source
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/codegen/models/log_integration.yaml | Adds data source configuration defining schema attributes and API operations for log integration reads |
| tools/codegen/models/alert_configuration_api.yaml | Updates documentation descriptions to remove specific API reference links |
| tools/codegen/config.yml | Adds data source configuration with API endpoint paths and schema aliases |
| internal/serviceapi/logintegration/resource_test.go | Adds data source acceptance tests and helper functions |
| internal/serviceapi/logintegration/data_source_schema.go | Auto-generated schema definition for the log integration data source |
| internal/serviceapi/logintegration/data_source.go | Auto-generated data source implementation with read operation |
| internal/serviceapi/alertconfigurationapi/data_source_schema.go | Updates documentation to remove API reference links |
| internal/provider/provider.go | Registers the new data source in the provider |
| Makefile | Adds add-datasource-if-exists target to automatically register data sources |
| .changelog/3978.txt | Adds changelog entry for the new data source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcosuma
approved these changes
Dec 12, 2025
Comment on lines
25
to
28
| "id": dsschema.StringAttribute{ | ||
| Required: true, | ||
| MarkdownDescription: "Unique identifier of the log integration configuration.", | ||
| }, |
Member
There was a problem hiding this comment.
should we already add the alias we agreed in the technical design?
id defined as integration_id in both the resource and data source
QuiqueSanMongo
approved these changes
Dec 12, 2025
Contributor
QuiqueSanMongo
left a comment
QuiqueSanMongo
left a comment
There was a problem hiding this comment.
LGTM; just a small comment
| present_in_any_response: false | ||
| request_only_required_on_create: false | ||
| - string: {} | ||
| description: S3 directory path prefix where the log files will be stored. MongoDB Cloud will add further sub-directories based on the log type. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: S3 directory path prefix where the log files will be stored. MongoDB Cloud will add further sub-directories based on the log type. | |
| description: S3 directory path prefix where the log files will be stored. MongoDB Cloud adds further sub-directories based on the log type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mongodbatlas_log_integrationdata source and added it to the provider.make enable-autogenso that it also adds singular data sources to the provider.Link to any related issue(s): CLOUDP-361983
Type of change:
Required Checklist:
Further comments