Skip to content

fix: Support pool_maxsize parameter for concurrent connections #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kitaekatt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Support pool_maxsize parameter for concurrent connections #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions requests_unixsocket/adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ def connect(self):

class UnixHTTPConnectionPool(urllib3.connectionpool.HTTPConnectionPool):

def __init__(self, socket_path, timeout=60):
def __init__(self, socket_path, timeout=60, maxsize=1, **kwargs):
Copy link
Collaborator

@webknjaz webknjaz Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value upstream is 10: docker/docker-py@be7d0f0#diff-25eefff144d019c2dcb7e072a6a380825e67c192831eef3d59ca5ea2ca65aa17.

@mupuf should we mimic that?

Copy link
Collaborator

@mupuf mupuf Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the original version should have mirrored the upstream default... but this ship has sailed now and we don't want to regress on someone's code just for purity.

Let's start an issue about things that we want to fix for the next major version? There we could address your comment above about redefining private method.

super(UnixHTTPConnectionPool, self).__init__(
'localhost', timeout=timeout)
'localhost', timeout=timeout, maxsize=maxsize, **kwargs)
self.socket_path = socket_path
self.timeout = timeout

Expand All @@ -51,9 +51,11 @@ def _new_conn(self):

class UnixAdapter(HTTPAdapter):

def __init__(self, timeout=60, pool_connections=25, *args, **kwargs):
def __init__(self, timeout=60, pool_connections=25, pool_maxsize=1,
*args, **kwargs):
super(UnixAdapter, self).__init__(*args, **kwargs)
self.timeout = timeout
self.pool_maxsize = pool_maxsize
self.pools = urllib3._collections.RecentlyUsedContainer(
pool_connections, dispose_func=lambda p: p.close()
)
Expand All @@ -75,7 +77,7 @@ def get_connection(self, url, proxies=None):
if pool:
return pool

pool = UnixHTTPConnectionPool(url, self.timeout)
pool = UnixHTTPConnectionPool(url, self.timeout, maxsize=self.pool_maxsize)
self.pools[url] = pool

return pool
Expand Down
Loading