-
Notifications
You must be signed in to change notification settings - Fork 154
Preserve external controller annotations for deployment and daemonSet #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
==========================================
- Coverage 86.23% 86.20% -0.04%
==========================================
Files 132 132
Lines 14557 14560 +3
Branches 35 35
==========================================
- Hits 12553 12551 -2
- Misses 1792 1794 +2
- Partials 212 215 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At this point, we could cherrypick this into 2.3 since we haven't released yet. |
bjee19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job
2610d91 to
274e713
Compare
6821a8d to
a26f7d6
Compare
…#4468) Problem: Users want that deployments and daemonSet preserve external annotations like how we do for services Solution: Adds a solution to track internal annotations and preserver external annotations.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want that deployments and daemonSet preserve external annotations like how we do for services
Solution: Adds a solution to track internal annotations and preserver external annotations.
Testing: I verified the behavior by manually adding an annotation to both to deployment and waiting if controller overwrites it and watching the generation
Daemonset
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #4447
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.