Skip to content

Conversation

@jankapunkt
Copy link
Member

Summary

We need to bump node versions as the ecosystem moves quick and ESM becomes more and more the defacto standard (see related discussion #279).

For now we only bump the ci versions but remain backwards compatible. However, the module related issues become more frequent and we need to make a clear cut soon.

Linked issue(s)

none

Involved parts of the project

CI

Added tests?

none

OAuth2 standard

not relevant

Reproduction

see actions

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflows to use Node.js versions 20, 22, and 24, dropping support for Node 16 and 18 in CI testing. The changes aim to prepare for the ecosystem's move toward ESM as the default standard while the codebase remains backwards compatible (as noted in the PR description).

Key Changes

  • Updated test matrix from [16, 18, 20, 22] to [20, 22, 24] across both CI workflows
  • Changed lint and audit job Node versions from 20 to 24
  • Changed publish job Node versions from 16 to 24
  • Increased minimum coverage requirement from 95% to 98%

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/tests.yml Updated lint job to Node 24, test matrix to [20, 22, 24], and min_coverage to 98
.github/workflows/tests-release.yml Updated audit, publish-dry-run, and publish jobs to Node 24, test matrix to [20, 22, 24], and min_coverage to 98

Note: While this PR updates CI Node versions, the package.json engines field still specifies >=16.0.0 and the README.md still references Node 16. These files should be updated in coordination with this CI change to maintain consistency across the codebase, though they are outside the scope of the current diff.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jankapunkt jankapunkt merged commit 8a715c9 into master Dec 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants