feat(v8): add command to sync V8 deps #1016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
git node v8 depsto (re)sync V8 dependencies from V8'sDEPSfile.I started on this while exploring potentially adding Chromium's Rust crates (
third_party/rust) to the Node.js source tree (although it looks like we might do our own vendoring to potentially allow other uses of Rust). It will also be useful for exploring addingthird_party/libc++/srcfor V8's custom_libcxx to avoid requiring libatomic.On its own it shouldn't do anything (other than revert any patches we have floated on top of the third_party deps). Its main use would be to test updates to
lib/update-v8/constants.jsor even V8's DEPS (if we ever want to roll forward a dependency (I expect that to be rare/unlikely)).