-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] Sales: Optional Products section and more #15841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theRealThagomizer
wants to merge
1
commit into
19.0
Choose a base branch
from
19.0-sales-optional-products-correction-thjud
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[IMP] Sales: Optional Products section and more #15841
theRealThagomizer
wants to merge
1
commit into
19.0
from
19.0-sales-optional-products-correction-thjud
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
meval1006
approved these changes
Dec 24, 2025
Contributor
meval1006
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @theRealThagomizer , left some minor edits and a suggestion rewrite. Good job.
| Products` and choose a product. | ||
|
|
||
| Ensure that the product's :guilabel:`Sales` checkbox is checked and click the :guilabel:`Sales` tab. | ||
| Under :guilabel:`Upsell & Cross-sell` heading, the :guilabel:`Optional Products` drop-down menu |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| Under the :guilabel:`Upsell & Cross-sell` heading, the :guilabel:`Optional Products` drop-down menu |
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: meval1006 <meval@odoo.com>
410f60b to
0746fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Hi, @meval1006! Got a pretty quick update to the new-ish Optional Products page. There's a new section about adding an optional products section into quotations. Not too much to say about it beyond that. Thanks for reviewing!
This 19.0 PR can be FWP up to master.