[ADD] real_estate: init real estate addon #1065

Oussema39 · 2025-12-15T14:00:01Z

No description provided.

robodoo · 2025-12-15T14:00:03Z

…actions

ushyme

Good work so far. Just a few remarks.

ushyme · 2025-12-17T15:54:21Z

.vscode/settings.json

+{
+  "cSpell.words": ["odoo"]
+}


Suggested change

{

"cSpell.words": ["odoo"]

}

This file should be removed. Editor-specific settings do not belong in the source code of an Odoo module.

ushyme · 2025-12-17T16:11:41Z

estate/models/estate_property.py

+    description = fields.Text('Description')
+    active = fields.Boolean(default=True)
+    postcode = fields.Char('Postcode')
+    date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False)


Suggested change

date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False)

date_availability = fields.Date('Available From',default=lambda self: fields.Date.context_today(self) + timedelta(days=90), copy=False)

Here, it's better to use fields.Date.context_today() for setting a default to the current date, because it correctly handles the user's timezones.

ushyme · 2025-12-19T11:41:45Z

estate/views/estate_property_views.xml

+    <field name="view_mode">list,form</field>
+  </record>
+
+  <record id="estate_property_taf_action" model="ir.actions.act_window">


Suggested change

<record id="estate_property_taf_action" model="ir.actions.act_window">

<record id="estate_property_tag_action" model="ir.actions.act_window">

This is just a small typo, but it means that the estate_property_tag_menu_action menu item that references this action is not working

ushyme · 2025-12-19T11:42:51Z

estate/models/estate_property.py

+    garden = fields.Boolean('Garden')
+    garden_area = fields.Integer('Garden area')
+    garden_orientation = fields.Selection(
+        string='type',


why "type" ?

estate/views/estate_property_views.xml

ushyme · 2025-12-19T11:46:43Z

estate/views/estate_property_views.xml

+      <search string="Search Properties">
+        <field name="name" string="Title" />
+        <field name="postcode" string="Postcode" />
+        <field name="expected_price" string="Postcode" />


Suggested change

<field name="expected_price" string="Postcode" />

<field name="expected_price" string="Expected Price" />

Small copy-paste error.

estate/views/estate_property_views.xml

…rresponding views

…y and offer models

…tialization files

…relationships and views

ushyme

There are a few that could be improved.

for the cancelled state, you are often comparing it with 'canceled' (missing l). This typo makes lot of you logic incorrect.
a few files are missing a new line at the end
the runbot is still red

ushyme · 2025-12-23T15:33:29Z

estate/models/estate_property.py

+    @api.depends("create_date", "validity")
+    def _compute_date_deadline(self):
+        for record in self:
+            if record.create_date:
+                record.date_deadline = (
+                    record.create_date.date() + timedelta(days=record.validity)
+            )
+            else:
+                record.date_deadline = fields.Date.context_today(self)


What's the point of this ? Where is the validity field comming from ?

ushyme · 2025-12-23T15:37:34Z

estate/models/estate_property_offer.py

+    @api.depends("create_date", "validity")
+    def _compute_date_deadline(self):
+        for record in self:
+            if record.create_date:
+                record.date_deadline = (
+                    record.create_date.date()
+                    + timedelta(days=record.validity)
+                )
+            else:
+                record.date_deadline = False
+
+    @api.depends("create_date", "validity")
+    def _compute_date_deadline(self):
+        for record in self:
+            if record.create_date:
+                record.date_deadline = (
+                    record.create_date.date() + timedelta(days=record.validity)
+            )
+            else:
+                record.date_deadline = fields.Date.context_today(self)


I'm guessing a small copy-paste mistake ?

ushyme · 2025-12-23T15:47:22Z

estate/models/estate_property.py

+        return True
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):


Suggested change

def _check_selling_price(self):

def _check_selling_price_value(self):

you already used the name _check_selling_price for a constraint earlier. While this technically should work, it’s confusing for maintenance.

ushyme · 2025-12-23T15:49:55Z

estate/views/estate_property_views.xml

+                  <field name="garden" class="mb4" />
+                  <field name="garden" />


why duplicate the fields ?

ushyme · 2025-12-23T15:50:19Z

estate/views/estate_property_views.xml

+                  <field name="garden" />
+                  <field name="garden_area" invisible="not garden" />
+                  <field name="garden_orientation" invisible="not garden" />
+                  <field name="garden_orientation" class="mb4" />


same question here

ushyme · 2025-12-23T15:52:58Z

estate/views/estate_property_offer_views.xml

+          type="object"
+          icon="fa-check"
+          invisible="status"
+          title="action_accept_btn"


In Odoo, the title attribute on a button provides a tooltip. It is better to use a human-readable string like title="Accept Offer" so users know what the icon does when they hover over it.

This applies to all the other button title attributes in your code.

[ADD] real_estate: init real estate addon

7e844b7

Oussema Heni added 6 commits December 15, 2025 16:42

[ADD] real_estate: add estate property model and its props

f5d86c5

[ADD] real_estate: add estate model security rules

fe45480

[ADD] real_estate: changes in the views of the model to add menu and …

ac62922

…actions

[IMP] real_estate: add list columns and form fields

7ec5101

[IMP] real_estate: add search and filters in estate properties list

90cf058

[IMP] real_estate: add property type and tags models

580267f

ushyme reviewed Dec 19, 2025

View reviewed changes

Oussema Heni added 5 commits December 19, 2025 15:18

[IMP] real_estate: implement property offers, types, and tags with co…

9fea900

…rresponding views

[IMP] real_estate: add computed values and onchange to estate propert…

a9406d3

…y and offer models

[FIX] real_estate: ensure proper formatting in manifest and model ini…

db55157

…tialization files

[IMP] real_estate: add action methods and models constraints

99386a7

[IMP] real_estate: add ordering to property and offer models, update …

c3b4579

…relationships and views

Oussema39 force-pushed the 19.0-real-estate-addon-ouelh branch from 5c091f1 to c3b4579 Compare December 23, 2025 10:06

[IMP] real_estate: add property management to users,

fc72dc5

ushyme reviewed Dec 23, 2025

View reviewed changes

Oussema Heni added 2 commits December 24, 2025 13:32

[IMP] estate_account: add accounting features to estate property

10752a7

[IMP] real_estate: add kanban view for estate properties

73dbe79

Oussema39 force-pushed the 19.0-real-estate-addon-ouelh branch from 85a7703 to 73dbe79 Compare December 24, 2025 14:44

	date_availability = fields.Date('Available From',default=lambda self: fields.Date.today() + timedelta(days=90), copy=False)
	date_availability = fields.Date('Available From',default=lambda self: fields.Date.context_today(self) + timedelta(days=90), copy=False)

	<record id="estate_property_taf_action" model="ir.actions.act_window">
	<record id="estate_property_tag_action" model="ir.actions.act_window">

	<field name="expected_price" string="Postcode" />
	<field name="expected_price" string="Expected Price" />

	def _check_selling_price(self):
	def _check_selling_price_value(self):

[ADD] real_estate: init real estate addon #1065

Are you sure you want to change the base?

[ADD] real_estate: init real estate addon #1065

Uh oh!

Conversation

Oussema39 commented Dec 15, 2025

Uh oh!

robodoo commented Dec 15, 2025

Uh oh!

ushyme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ushyme left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ushyme Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ushyme left a comment •

edited

Loading

ushyme Dec 23, 2025 •

edited

Loading