-
Notifications
You must be signed in to change notification settings - Fork 2.8k
real estate module (ibmah) #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
amah-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with the first review 🎉
19f4418 to
078c9bb
Compare
amah-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mainly about the commit msg let's try working to have the chapter number in the commit header (commit first line) and I want you to add some description for each commit body with what is done in this chapter
bcec691 to
20f7abf
Compare
20f7abf to
81cede7
Compare
Chapter 7 This adds tags to properties, lists offers made (whether refued or accepted) along with the salesperson and buyer in "Other info" tab
81cede7 to
a2ae3a1
Compare
…updates Chapter 8
Chapter 9 This introduces marking a property as "Sold" or "Cancelled". It also allows for easier offers management from the list view and it gets reflected automatically on the property
… tags and types Chapter 10 This commit adds checks on property and offer prices to ensure they are positive and that no property sells for less than 90% of the expected price. It also ensures the uniqueness of property tags and types.
amah-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments about .py structure you can refer to this DOC to know about it all
…dels Chapter 11: Implement inlinen view for properties by their type, add statusbar and tag color picker widgets, implement stat button for displaying the number of offers for each property type
c5ecc21 to
647d085
Compare
Chapter 12 This overrides deletion methods to make them safer by only allowing deletion of new or cancelled properties. It integrates the real estate module with the views for 'res.users' model by adding a new page listing the properties managed by each user
…e invoices on sales Chapter 13 This introduces a link module "estate_account" that enables real estate module to generate invoices automatically on sold houses.
Chapter 14 This implements kanban views using QWeb template definition
Chapter 15 This addresses warnings and various runbot-reported issues.

closes #1062. This one is based on master instead of v19.0