Skip to content

Conversation

@ibmah-odoo
Copy link

closes #1062. This one is based on master instead of v19.0

@robodoo
Copy link

robodoo commented Dec 15, 2025

Pull request status dashboard

@ibmah-odoo ibmah-odoo changed the base branch from 19.0 to master December 15, 2025 14:54
@amah-odoo amah-odoo self-requested a review December 15, 2025 15:11
Copy link

@amah-odoo amah-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the first review 🎉

@ibmah-odoo ibmah-odoo force-pushed the master-real-estate-ibmah branch from 19f4418 to 078c9bb Compare December 16, 2025 12:31
Copy link

@amah-odoo amah-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly about the commit msg let's try working to have the chapter number in the commit header (commit first line) and I want you to add some description for each commit body with what is done in this chapter

@ibmah-odoo ibmah-odoo force-pushed the master-real-estate-ibmah branch 2 times, most recently from bcec691 to 20f7abf Compare December 16, 2025 15:30
@ibmah-odoo ibmah-odoo force-pushed the master-real-estate-ibmah branch from 20f7abf to 81cede7 Compare December 16, 2025 15:52
Chapter 7

This adds tags to properties, lists offers made (whether refued or
accepted) along with the salesperson and buyer in "Other info" tab
@ibmah-odoo ibmah-odoo force-pushed the master-real-estate-ibmah branch from 81cede7 to a2ae3a1 Compare December 17, 2025 12:41
Chapter 9

This introduces marking a property as "Sold" or "Cancelled".

It also allows for easier offers management from the list view and it
gets reflected automatically on the property
… tags and types

Chapter 10

This commit adds checks on property and offer prices to ensure they are
positive and that no property sells for less than 90% of the expected
price. It also ensures the uniqueness of property tags and types.
Copy link

@amah-odoo amah-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments about .py structure you can refer to this DOC to know about it all

…dels

Chapter 11:

Implement inlinen view for properties by their type, add statusbar and
tag color picker widgets, implement stat button for displaying the
number of offers for each property type
@ibmah-odoo ibmah-odoo force-pushed the master-real-estate-ibmah branch from c5ecc21 to 647d085 Compare December 23, 2025 09:24
Chapter 12
This overrides deletion methods to make them safer by only allowing deletion of new or cancelled properties.
It integrates the real estate module with the views for 'res.users' model by adding a new page listing the properties managed by each user
…e invoices on sales

Chapter 13

This introduces a link module "estate_account" that enables real estate
module to generate invoices automatically on sold houses.
Chapter 14

This implements kanban views using QWeb template definition
Chapter 15

This addresses warnings and various runbot-reported issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants