[ADD] estate: Add initial module structure with property model #1072

SurryaT10 · 2025-12-15T15:36:21Z

Initialized Estate module and created 'estate_property' model.

…nifest. Created 'estate_property' model and fields.

robodoo · 2025-12-15T15:36:24Z

lost-odoo · 2025-12-16T10:50:46Z

Hello, can you please ensure that your runbot is green 😄

Also added access rights for estate.property model

lost-odoo

Hello, I already made a small review. Not a big deal but just some nitpicking stuff that we try to avoid. 😄

estate/models/estate.py

estate/views/estate_menus.xml

estate/__manifest__.py

estate/views/estate_property_views.xml

lost-odoo · 2025-12-16T14:55:53Z

Also please don't forget to make one commit per chapter. Try to make a correct title. Don't hesitate to amend or squash your commits.

Added estate_property_views.xml which contains list and form views Added a separate estate_property_search_view.xml for search with filters for active and availability as well as group by based on postcode. Also addressed code review comments.

Added estate.property.type model which specifies the type of property. Eg: House/Apartment Added estate.property.tag model to indicate the tags(cozy, renovated) for each property Added estate.property.offer model which indicates the offers for each property. Also added views for each model mentioned above.

lost-odoo · 2025-12-18T09:32:47Z

Hey don't forget to close all the comments I did on the review when you did them 😄
Also please follow the git guidelines. ADD should only be used when you add a new module otherwise use IMP for an improvement.

total_area field is based on the size of both garden_area and living_area best_offer field is based on the max price among the list of offers Also added validity and deadline for the offers as a computed and inverse function impacting each other.

Added Sold and Cancel buttons: When a property is sold it cannot be canceled When a property is canceled it cannot be sold Added offer accept and rejected icon button: When an offer is accepted: 1. The selling price is automatically updated by button actions 2. Status changes to 'Offer Accepted' 3. Rejects all other offers Added an onchange, which updates the status to 'Offer Received' when there is an offer.

Added SQL constraints for expected_price, selling_price, property_tag_name and property_type_name Added python constraint for selling_price to be >= 90% of expected_price unless it is 0.0

estate/__manifest__.py

estate/models/estate.py

estate/models/property_tag.py

estate/models/offer.py

Added ordering for the following: property: Descending by ID offer: Descending by price tag: Name type: Name Added sequence ordering for type Added color field for property tag. Added invisible attribute for Sold, Cancel, Accept, Reject buttons Added color decorations for list view. Added offer count button to show the list of offers for a property type Fixed code review changes.

Added property_ids field for res.users model Added the 'property_ids' field in 'Properties for Sale' page in 'Users & Companies' menu Also removed trailing white spaces in estate.py selection fields

Added estate_account module Overrided the action_mark_sold method to create an invoice when property is marked as Sold Added 2 invoice lines: one for 6% of selling price - brokerage fee one for 100 - administrative fee

Added a Kandban view for Properties

LoganStaelens · 2025-12-24T13:53:17Z

estate/models/offer.py

+    @api.model
+    def create(self, vals_list):
+        for record in vals_list:
+            property = self.env['estate.property'].browse(record["property_id"])


Avoid browsing in a loop, try to batch it by making the browse outside the loop

LoganStaelens · 2025-12-24T13:59:50Z

estate/models/estate.py

+
+    def action_mark_sold(self):
+        for record in self:
+            if record.status == "canceled":


simple quotes 😄
Same at other places

LoganStaelens · 2025-12-24T14:06:29Z

estate/models/estate.py

+            record.best_price = max(record.offer_ids.mapped('price')) if record.offer_ids else 0.0
+
+    @api.onchange('offer_ids')
+    def _onchange_property_status(self):


I think it should be named _onchange_offer_ids because it is offer_ids that is changing 😄

LoganStaelens · 2025-12-24T14:13:51Z

estate/models/offer.py

+            if record.property_id.status == "offer_accepted" and record.property_id.buyer_id == record.partner_id:
+                record.property_id.selling_price = 0.0
+                record.property_id.buyer_id = False
+                record.property_id.status = "offer_received"


Does this make sense to reject an offer that got accepted ? Can a buyer make multiple offers ? if so then it is wrong I guess ?

LoganStaelens · 2025-12-24T14:16:10Z

estate/models/offer.py

+    def create(self, vals_list):
+        for record in vals_list:
+            property = self.env['estate.property'].browse(record["property_id"])
+            min_price = min(offer.price for offer in property.offer_ids) if property.offer_ids else 0


I don't think you are supposed to do that. The minimum price is 90 % of the property asked price.

Also when you do float comparisons, use float_compare.

LoganStaelens · 2025-12-24T14:17:26Z

estate/models/property_tag.py

+    color = fields.Integer("Color")
+
+    _unique_name = models.Constraint(
+        "UNIQUE(name)",


single quotes 👀

LoganStaelens · 2025-12-24T14:30:52Z

estate/views/estate_property_views.xml

+                <templates>
+                    <t t-name="card">
+                        <field name="name" class="fw-bold"/>
+                        <field name="status" invisible="1"/>


You could move that out of the card template and remove the invisible="1".

LoganStaelens · 2025-12-24T14:31:30Z

estate_account/__manifest__.py

+    'depends': ['base', 'web', 'estate', 'account'],
+    'data': [],
+    'application': True,
+    'license': 'AGPL-3'


Do not forget auto_install to auto install this module when all its dependencies are installed.

LoganStaelens · 2025-12-24T14:31:51Z

estate_account/__manifest__.py

+    'category': 'Tutorials',
+    'version': '1.0',
+
+    'depends': ['base', 'web', 'estate', 'account'],


Base and web are useless here as estate and account already depends on them 😄

LoganStaelens · 2025-12-24T14:32:46Z

estate_account/models/estate_property.py

+            self.env['account.move'].create({
+                'partner_id': record.buyer_id.id,
+                'move_type': "out_invoice",
+                'journal_id': self.env['account.journal'].search([('type', '=', 'sale')], limit=1).id,


Try to avoid doing search in loops even if it is unlikely to have multiple records to mark as sold at once 😄

[ADD] estate: Add initial module structure with property model and ma…

6f4b6ba

…nifest. Created 'estate_property' model and fields.

SurryaT10 added 3 commits December 16, 2025 14:57

[FIX] Fixed CI test issues

c955e4c

[Add] Added Estate menu and Properties action for estate.property model

70d8adf

Also added access rights for estate.property model

[FIX] Added missed imports for views and security in manifest file

6591727

lost-odoo requested changes Dec 16, 2025

View reviewed changes

SurryaT10 added 2 commits December 18, 2025 09:51

[ADD] Chapter 6: Build Views

2e143d9

Added estate_property_views.xml which contains list and form views Added a separate estate_property_search_view.xml for search with filters for active and availability as well as group by based on postcode. Also addressed code review comments.

SurryaT10 force-pushed the 19.0-estate-sutha branch from f23d67c to f11fc50 Compare December 18, 2025 09:01

lost-odoo and others added 2 commits December 18, 2025 10:39

DO NOT REMOVE THIS COMMIT

f337b30

SurryaT10 force-pushed the 19.0-estate-sutha branch from d33c5b0 to e512458 Compare December 18, 2025 14:45

SurryaT10 added 2 commits December 19, 2025 09:19

[IMP] Chapter 10: Constraints

5cb3109

Added SQL constraints for expected_price, selling_price, property_tag_name and property_type_name Added python constraint for selling_price to be >= 90% of expected_price unless it is 0.0

lost-odoo requested changes Dec 19, 2025

View reviewed changes

SurryaT10 force-pushed the 19.0-estate-sutha branch from 9a4342b to b5bcfe4 Compare December 22, 2025 13:28

SurryaT10 force-pushed the 19.0-estate-sutha branch from b5bcfe4 to 726eda7 Compare December 22, 2025 13:29

SurryaT10 added 3 commits December 23, 2025 10:49

[IMP] Chapter12: Inheritance

78752f3

Added property_ids field for res.users model Added the 'property_ids' field in 'Properties for Sale' page in 'Users & Companies' menu Also removed trailing white spaces in estate.py selection fields

[IMP] Chapter12: Inheritance

a15f91f

Added property_ids field for res.users model Added the 'property_ids' field in 'Properties for Sale' page in 'Users & Companies' menu Also removed trailing white spaces in estate.py selection fields

[ADD] Chapter 13: Interact With Other Modules

e8bf7f4

Added estate_account module Overrided the action_mark_sold method to create an invoice when property is marked as Sold Added 2 invoice lines: one for 6% of selling price - brokerage fee one for 100 - administrative fee

SurryaT10 force-pushed the 19.0-estate-sutha branch 2 times, most recently from d4377dc to 7603387 Compare December 23, 2025 15:21

[IMP] Chapter 14: A Brief History of QWeb

09c95d8

Added a Kandban view for Properties

SurryaT10 force-pushed the 19.0-estate-sutha branch from 7603387 to 09c95d8 Compare December 23, 2025 16:22

LoganStaelens suggested changes Dec 24, 2025

View reviewed changes

[ADD] estate: Add initial module structure with property model #1072

Are you sure you want to change the base?

[ADD] estate: Add initial module structure with property model #1072

Uh oh!

Conversation

SurryaT10 commented Dec 15, 2025

Uh oh!

robodoo commented Dec 15, 2025

Uh oh!

lost-odoo commented Dec 16, 2025

Uh oh!

lost-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lost-odoo commented Dec 16, 2025

Uh oh!

lost-odoo commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants