19.0 app traning raibr #1074

ramezlahzy · 2025-12-15T16:01:05Z

No description provided.

robodoo · 2025-12-15T16:01:08Z

lost-odoo · 2025-12-16T10:50:34Z

Hello, can you please ensure that your runbot is green 😄

…ange

… actions and offer acceptance

ramezlahzy · 2025-12-16T16:16:37Z

Hello, can you please ensure that your runbot is green 😄

Can you check again ;)

estate/security/ir.model.access.csv

estate/models/estate_property_offer.py

estate/models/estate_property.py

estate/__manifest__.py

README-raibr-docs.md

The models.Constraint syntax does not exist in Odoo's ORM. SQL constraints must be defined using the _sql_constraints class attribute.

estate/models/estate_property_offer.py

lost-odoo · 2025-12-19T10:22:18Z

estate/models/estate_property_type.py

+    property_ids = fields.One2many(comodel_name='estate.property', inverse_name='property_type_id', string="Properties")
+    offer_count = fields.Integer(compute='_compute_offer_count', string="Offer Count")
+
+    def _compute_offer_count(self):


Is it normal that you don't have an api.depends here ?

that function is called when that field calculated offer_count = fields.Integer(compute='_compute_offer_count', string="Offer Count") so, there is no need for any dependency

Yeah but I think you still need to add a dependency as if property_ids change it is not recomputed.

estate/views/estate_property_type_views.xml

estate/views/estate_property_views.xml

estate/views/estate_property_offer_views.xml

…ation

…tion with automatic invoice generation

…ted styles

LoganStaelens

Did another review.

LoganStaelens · 2025-12-24T12:12:33Z

estate/models/estate_property_type.py

+    property_ids = fields.One2many(comodel_name='estate.property', inverse_name='property_type_id', string="Properties")
+    offer_count = fields.Integer(compute='_compute_offer_count', string="Offer Count")
+
+    def _compute_offer_count(self):


Yeah but I think you still need to add a dependency as if property_ids change it is not recomputed.

LoganStaelens · 2025-12-24T12:24:03Z

estate/models/estate_property.py

+            if not float_is_zero(property.selling_price, precision_digits=2):
+                if float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:


Why doing two conditions ?

Suggested change

if not float_is_zero(property.selling_price, precision_digits=2):

if float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:

if not float_is_zero(property.selling_price, precision_digits=2) and float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:

LoganStaelens · 2025-12-24T12:28:33Z

estate/models/estate_property_offer.py

+            if offer.property_id.offer_ids.filtered(lambda o: o.status == 'accepted' and o.id != offer.id):
+                raise UserError(self.env._("Only one offer can be accepted per property."))


Can you not check the state of the property directly, instead of doing a filtering ?

LoganStaelens · 2025-12-24T13:44:25Z

estate/static/src/css/estate.css

+/* Estate Module Kanban View Styles */
+
+.o_kanban_record_title {
+    font-size: 16px;
+    font-weight: bold;
+    margin-bottom: 8px;
+    color: #212529;
+}
+
+.o_kanban_record_subtitle {
+    font-size: 13px;
+    color: #6c757d;
+    margin-bottom: 4px;
+}
+
+.o_kanban_tags_section {
+    margin-top: 8px;
+}


Try to at least put your module name to avoid collision with the rest of the css from odoo

LoganStaelens · 2025-12-24T13:46:45Z

estate_account/models/estate_property.py

+                        (
+                            0,
+                            0,
+                            {
+                                'name': 'Property price',
+                                'quantity': 1,
+                                'price_unit': property.selling_price,
+                            },
+                        ),


Here you could use Command.create from odoo.

LoganStaelens · 2025-12-24T13:47:43Z

estate_account/__manifest__.py

+    "data": [],
+    "application": False,
+    "license": "LGPL-3",
+}


Don't forget to add auto_install here so your bridge module is auto installed when all dependencies are installed.

odoo and others added 6 commits December 15, 2025 10:19

[ADD] estate: Initial module setup

9078a4d

[ADD] estate: Complete Chapter 1 requirements

b46dc7d

[ADD] estate: Complete Chapter 2 requirements

9d3e35d

[ADD] estate: Complete Chapter 3 requirements

afbf975

[ADD] estate: Minimum security configuration (Chapter 4)

c79e559

[ADD] estate: Property views and menus (Chapter 5)

27d7a39

[ADD] estate: Search filters and grouping options (Chapter 6)

fbb6c5e

[FIX] estate: Chapter 7 fixes

06b0b67

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from dc88f8d to 138ea5d Compare December 16, 2025 13:05

[FIX] estate: Chapter 7 corrections

e76dbf5

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from 138ea5d to c02245d Compare December 16, 2025 13:21

raibr added 3 commits December 16, 2025 16:05

[ADD] estate: Implement property offers with computed fields and onch…

23dc969

…ange

[ADD] estate(Chapter 9): Add property state workflow with sold/cancel…

7d28247

… actions and offer acceptance

[IMP] estate: Add .DS_Store to .gitignore

fcbae9f

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from b656e0e to fcbae9f Compare December 16, 2025 16:06

[IMP] estate: Fix ruff linting issues

90bef7f

ramezlahzy requested review from lost-odoo and removed request for lost-odoo December 17, 2025 08:51

lost-odoo requested changes Dec 17, 2025

View reviewed changes

ramezlahzy force-pushed the 19.0-app-traning-raibr branch 3 times, most recently from fd47ba1 to 54edce7 Compare December 18, 2025 16:32

[FIX] estate: replace invalid models.Constraint with _sql_constraints

806e103

The models.Constraint syntax does not exist in Odoo's ORM. SQL constraints must be defined using the _sql_constraints class attribute.

ramezlahzy force-pushed the 19.0-app-traning-raibr branch 2 times, most recently from ab9d9a6 to 4626609 Compare December 19, 2025 09:10

[FIX] estate: replace invalid models.Constraint with _sql_constraints

f073fa7

The models.Constraint syntax does not exist in Odoo's ORM. SQL constraints must be defined using the _sql_constraints class attribute.

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from 4626609 to f073fa7 Compare December 19, 2025 09:19

ramezlahzy requested a review from lost-odoo December 19, 2025 09:23

lost-odoo requested changes Dec 19, 2025

View reviewed changes

[IMP] estate: Implement salesperson management with properties associ…

8e85311

…ation

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from e97a713 to 8e85311 Compare December 19, 2025 14:44

raibr added 3 commits December 22, 2025 08:56

[IMP] estate_account (Chapter 13): Add Real Estate Accounting integra…

9259a91

…tion with automatic invoice generation

[IMP] estate (Chapter 14): Add Kanban view for properties and associa…

35673d8

…ted styles

[IMP] estate: fix some linting problem

9c4e958

ramezlahzy force-pushed the 19.0-app-traning-raibr branch from d6f0df1 to 9c4e958 Compare December 22, 2025 12:17

ramezlahzy requested a review from lost-odoo December 23, 2025 08:06

LoganStaelens suggested changes Dec 24, 2025

View reviewed changes

		if not float_is_zero(property.selling_price, precision_digits=2):
		if float_compare(property.selling_price, property.expected_price * 0.9, precision_digits=2) < 0:

		if offer.property_id.offer_ids.filtered(lambda o: o.status == 'accepted' and o.id != offer.id):
		raise UserError(self.env._("Only one offer can be accepted per property."))

19.0 app traning raibr #1074

Are you sure you want to change the base?

19.0 app traning raibr #1074

Uh oh!

Conversation

ramezlahzy commented Dec 15, 2025

Uh oh!

robodoo commented Dec 15, 2025

Uh oh!

lost-odoo commented Dec 16, 2025

Uh oh!

ramezlahzy commented Dec 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LoganStaelens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LoganStaelens left a comment •

edited

Loading