[ADD] estate: add real estate module (framework 101 tutorial) #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robal-odoo
force-pushed
the
19.0-estate-tutorial-robal
branch
from
924f90b to
0af92ad
Compare
robal-odoo
changed the title
robal-odoo
force-pushed
the
19.0-estate-tutorial-robal
branch
from
cab625c to
d8993d0
Compare
ushyme
reviewed
Dec 19, 2025
ushyme
left a comment
ushyme
left a comment
There was a problem hiding this comment.
Good work so far. I just have a few suggestions.
robal-odoo
force-pushed
the
19.0-estate-tutorial-robal
branch
from
2fb7576 to
9dd3005
Compare
Framework 101 tutorial - add estate module - add estate_account module for integration with invoicing
robal-odoo
force-pushed
the
19.0-estate-tutorial-robal
branch
from
440b49e to
6b2e660
Compare
ushyme
reviewed
Dec 23, 2025
| @api.model | ||
| def create(self, vals): | ||
| for val in vals: | ||
| estate_property = self.env["estate.property"].browse(val["property_id"]) |
There was a problem hiding this comment.
If vals contains offers for multiple properties, this will trigger multiple singleton browses.
Extract all property_ids from vals first, browse them in one go, and then iterate.
Comment on lines
50
to
60
| def action_accept(self) -> bool: | ||
| # TODO double check validation | ||
| for record in self: | ||
| if record.property_id.offer_ids.filtered(lambda r: r.status == "accepted"): | ||
| raise UserError(record.env._("Cannot accept this offer because another offer has already been accepted for the property.")) | ||
|
|
||
| record.status = "accepted" | ||
| record.property_id.selling_price = record.price | ||
| record.property_id.buyer_id = record.partner_id | ||
| record.property_id.state = "offer_accepted" | ||
| return True |
There was a problem hiding this comment.
what if the property is already sold or cancelled ?
Comment on lines
7
to
21
| def action_set_sold(self) -> bool: | ||
| percent_description = "6 percent of selling price" | ||
| admin_fee_description = "Administrative fees" | ||
| # Note: does not work if fiscal localization is not set | ||
| for record in self: | ||
| account_move = { | ||
| "partner_id": record.buyer_id.id, | ||
| "move_type": "out_invoice", | ||
| "invoice_line_ids": [ | ||
| Command.create({"name": percent_description, "quantity": 1, "price_unit": 0.06 * record.selling_price}), | ||
| Command.create({"name": admin_fee_description, "quantity": 1, "price_unit": 100.0}), | ||
| ], | ||
| } | ||
| self.env["account.move"].create(account_move) | ||
| return super().action_set_sold() |
There was a problem hiding this comment.
Currently, you are calling self.env["account.move"].create(account_move) inside the loop. This triggers an INSERT and potentially multiple compute/inverse calls per record.
Also, what if the buyer_id is not set ?
- Stop user from accepting offers if the linked property is sold or cancelled
- Move the call to "create" outside the loop
- Extract the calls to "browse" outside the loop
- Stop properties from being marked as sold if there isn't an accepted offer
- Leverage the validation logic from the parent model - That validation already ensures there is an accepted offer, which means that buyer_id is set
…accept, refuse) - Cannot change the status of an offer if it's already set - Cannot accept/refuse offers on a property that's cancelled or sold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.