Tutorials - mobar #1079
Open
Tutorials - mobar #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mobar-odoo
force-pushed
the
master-tutorials-mobar
branch
from
8d0dd85 to
e313e75
Compare
ushyme
reviewed
Dec 23, 2025
ushyme
left a comment
ushyme
left a comment
There was a problem hiding this comment.
Looks good 👍🏾! Just a few tiny remarks.
| @@ -0,0 +1,15 @@ | |||
| { | |||
| 'name': 'Estate', | |||
| 'author': 'mobar', | |||
There was a problem hiding this comment.
Suggested change
| 'author': 'mobar', | |
| 'author': 'Odoo S.A.', |
As an employee, you work in the name of Odoo.
| from odoo import fields, models | ||
|
|
||
|
|
||
| class RecurringPlan(models.Model): |
There was a problem hiding this comment.
Suggested change
| class RecurringPlan(models.Model): | |
| class EstateProperty(models.Model): |
The Python class name should follow the CamelCase version of the model's _name.
Comment on lines
+7
to
+14
| <menuitem id="estate_property_menu" | ||
| name="Advertisements" | ||
| parent="estate_menu_root"/> | ||
|
|
||
| <menuitem id="estate_property_menu_action" | ||
| name="Properties" | ||
| parent="estate_property_menu" | ||
| action="estate_property_action"/> |
There was a problem hiding this comment.
Suggested change
| <menuitem id="estate_property_menu" | |
| name="Advertisements" | |
| parent="estate_menu_root"/> | |
| <menuitem id="estate_property_menu_action" | |
| name="Properties" | |
| parent="estate_property_menu" | |
| action="estate_property_action"/> | |
| <menuitem id="estate_advertisements_menu" | |
| name="Advertisements" | |
| parent="estate_menu_root"/> | |
| <menuitem id="estate_property_menu" | |
| name="Properties" | |
| parent="estate_property_menu" | |
| action="estate_property_action"/> |
Menu item IDs should be descriptive of what they represent.
Also, you can nest the menuitems to make the hierarchy easier to read.
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | ||
| access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 | ||
| access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1 | ||
| access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 No newline at end of file |
There was a problem hiding this comment.
Suggested change
| access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 | |
| access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 | |
Missing newline at end of file.
This also applies to all your xml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.