Skip to content

Limit init valid hex array to range that can be true #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baolongnt wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Limit init valid hex array to range that can be true #7809

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16d68f8
Lazy init valix hex array
baolongnt Nov 3, 2025
652457b
Add @Nullable
baolongnt Nov 3, 2025
474b0e4
Change to lazy init values only
baolongnt Nov 4, 2025
5e93095
Apply Spotless
baolongnt Dec 13, 2025
2770b7c
Switch to only init between the extreme HEX values (vs all 64K)
baolongnt Dec 13, 2025
4e6d274
Trigger Build
baolongnt Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions api/all/src/main/java/io/opentelemetry/api/internal/OtelEncodingUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ private static byte[] buildDecodingArray() {

private static boolean[] buildValidHexArray() {
boolean[] validHex = new boolean[Character.MAX_VALUE];
for (int i = 0; i < Character.MAX_VALUE; i++) {
validHex[i] = (48 <= i && i <= 57) || (97 <= i && i <= 102);
// Use the fact that the default initial boolean value is false
// and only explicitly init the values between the extreme HEX values
// This minimized impact during process startup esp. on mobile.
for (int i = 48; i < 103; i++) {
validHex[i] = i <= 57 || 97 <= i;
}
return validHex;
}
Expand Down
Loading