Update to opentelemetry-configuration 1.0.0-rc.3 #7861

anuraaga · 2025-11-20T07:33:54Z

I was curious if I can update config to start implementing the composite samplers in file config and little did I realize what I was getting myself into ;) But having started, went ahead and chugged through it. Not sure what the right time for this is so will leave it in draft but let me know whenever we should go forward with it, or also feel free to do an initial review even while draft if desired. /cc @jack-berg

codecov · 2025-11-20T07:41:15Z

Codecov Report

❌ Patch coverage is 88.42105% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.08%. Comparing base (04642a0) to head (bc11574).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
.../fileconfig/ComposableRuleBasedSamplerFactory.java	89.88%	5 Missing and 4 partials ⚠️
...incubator/fileconfig/ComposableSamplerFactory.java	66.66%	4 Missing and 2 partials ⚠️
...extension/incubator/fileconfig/FileConfigUtil.java	0.00%	4 Missing ⚠️
...extension/incubator/fileconfig/SamplerFactory.java	85.71%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7861      +/-   ##
============================================
- Coverage     90.10%   90.08%   -0.02%     
- Complexity     7325     7393      +68     
============================================
  Files           825      829       +4     
  Lines         22051    22395     +344     
  Branches       2179     2228      +49     
============================================
+ Hits          19868    20174     +306     
- Misses         1504     1528      +24     
- Partials        679      693      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zeitlinger · 2025-11-20T08:14:21Z

I also want to add support for open-telemetry/opentelemetry-configuration#376

anuraaga · 2025-11-20T08:24:12Z

Thanks for the pointer @zeitlinger - this PR allows parsing them but doesn't update PrometheusComponentProvider. From what I can tell, the entire exporter needs to be updated to undeprecate this?

https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusHttpServerBuilder.java#L87

I'm not sure if we would first do that before updating configuration, or do it together, happy to go with any approach.

zeitlinger · 2025-11-20T11:13:16Z

to undeprecate this?

it was deprecated because it had a different meaning

old: disable scope metric
new: disable scope label

I think it's fine to the change together - happy to help out

anuraaga · 2025-11-21T04:53:09Z

Thanks @zeitlinger - IIUC, there is currently no knob for the labels either

https://github.com/open-telemetry/opentelemetry-java/pull/7398/files#diff-bbf676997f34316d365def54b1ca5e2e4e65ecf892a045ca4008b353e1e2838eR460

If the knobs were already there, wiring them into declarative config would be simple, but if we need to add (or restore) new ones, I guess we should use a separate PR since they're for public API?

zeitlinger · 2025-11-21T06:10:40Z

Thanks @zeitlinger - IIUC, there is currently no knob for the labels either

correct

If the knobs were already there, wiring them into declarative config would be simple, but if we need to add (or restore) new ones, I guess we should use a separate PR since they're for public API?

I think it doesn't matter if it's public API, because we would document it either way - but a separate PR is also fine

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java

...ubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/SamplerFactory.java

jack-berg · 2025-11-25T15:14:20Z

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java

+      resource = model.getOtlpHttp();
+    }
+    if (model.getOtlpGrpc() != null) {
+      requireNullResource(resource, RESOURCE_NAME, model.getAdditionalProperties());


Adding strictness here to fail fast?

I think this was to reproduce the max-1 check from the previous map/compute approach

https://github.com/open-telemetry/opentelemetry-java/pull/7861/changes#diff-91f44a38e1a296b228f5ea28e90f69e0ff17939e2c5dc5234b4e9950edf5a530L37

I think I understand the intent: if oitlp_http is present, make sure no other span exporters are set. But the implementation seems not quite right. requireNullResource produces an error message like Invalid configuration - multiple " + resourceName + "s set: " + additionalProperties.keySet().stream().collect(joining(",", "[", "]" based on additional properties, when its model.getOtlpHttp() which is causing the conflict.

The old implementation works because I was sort of cheating and moving all the well known exporter model definitions to additionalProperties.

I pushed bc11574 which sort of reverts this change but does it without polluting additionalProperties.

Thinking about this, I need to go apply this pattern to SamplerFactory, LgRecordProcessorFactory, SpanProcessorFactory, TextMapPropagatorFactory, AggregationFactory. In all these cases, exactly one key value pair is expected but the implementations tolerate multiple. Will do this in a followup PR.

jack-berg

Thanks a lot, looks good! Can't merge it until opentelemetry-configuration cuts a release, but we can use this as a working branch.

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ComposableSamplerFactory.java

jack-berg · 2025-12-11T19:35:23Z

...a/io/opentelemetry/sdk/extension/incubator/fileconfig/ComposableRuleBasedSamplerFactory.java

+import java.util.function.Predicate;
+import javax.annotation.Nullable;
+
+final class ComposableRuleBasedSamplerFactory


@anuraaga went ahead and implemented the ExperimentalComposableRuleBasedSampler type.

One thing that caught me by surprise was that you can't say something like WHERE http.request.method = GET AND http.route = /users/:id, since the attribute conditions can only match against a single attribute key. Well, technically you could match against two attribute keys by setting both .attribute_values and .attribute_patterns. WDYT? Am I overestimating how common this type of thing will be?

jack-berg · 2025-12-11T19:36:55Z

...a/io/opentelemetry/sdk/extension/incubator/fileconfig/ComposableRuleBasedSamplerFactory.java

+    }
+    return new AttributeMatcher(
+        requireNonNull(attributeValuesModel.getKey(), "attribute_values key"),
+        IncludeExcludePredicate.createExactMatching(attributeValuesModel.getValues(), null));


Leaning on this IncludeExcludePredicate utility even when attribute_values doesn't have an exclude list because its convenient and already has a toString() implemented, which we declarative config tests rely on.

…y-java into update-fileconfig

jack-berg · 2025-12-18T16:46:32Z

Anyone other @open-telemetry/java-approvers planning on looking at this?

jkwatson · 2025-12-18T17:14:16Z

Anyone other @open-telemetry/java-approvers planning on looking at this?

not I!

anuraaga

Thanks @jack-berg - can't approve my own PR but LGTM

anuraaga · 2025-12-19T02:05:22Z

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java

+      resource = model.getOtlpHttp();
+    }
+    if (model.getOtlpGrpc() != null) {
+      requireNullResource(resource, RESOURCE_NAME, model.getAdditionalProperties());


I think this was to reproduce the max-1 check from the previous map/compute approach

https://github.com/open-telemetry/opentelemetry-java/pull/7861/changes#diff-91f44a38e1a296b228f5ea28e90f69e0ff17939e2c5dc5234b4e9950edf5a530L37

otelbot · 2025-12-19T20:50:18Z

Thank you for your contribution @anuraaga! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

anuraaga added 3 commits November 20, 2025 16:30

Update to latest unreleased opentelemetry-configuration

3c0e39d

Drift

c5a268f

Cleanup

b5e73dd

anuraaga requested a review from a team as a code owner November 20, 2025 07:33

anuraaga marked this pull request as draft November 20, 2025 07:33

jack-berg reviewed Nov 25, 2025

View reviewed changes

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/LogRecordExporterFactory.java Outdated Show resolved Hide resolved

jack-berg reviewed Nov 25, 2025

View reviewed changes

...ubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/SamplerFactory.java Show resolved Hide resolved

jack-berg reviewed Nov 25, 2025

View reviewed changes

jack-berg added 3 commits November 25, 2025 09:19

update to latest with single file schema

02290c2

update to latest ref as of 12/10

61fe08c

remove task for deleting type_descriptions.yaml

20d944a

jack-berg reviewed Dec 10, 2025

View reviewed changes

.../main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ComposableSamplerFactory.java Outdated Show resolved Hide resolved

jack-berg mentioned this pull request Dec 10, 2025

Prepare for 1.0-rc.3 release open-telemetry/opentelemetry-configuration#456

Merged

Add ExperimentalComposableRuleBasedSamplerModel implementation

10b06bd

jack-berg reviewed Dec 11, 2025

View reviewed changes

jack-berg added 2 commits December 11, 2025 14:33

Update to rc.3

3672a2d

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

032795e

…y-java into update-fileconfig

jack-berg marked this pull request as ready for review December 11, 2025 20:41

anuraaga mentioned this pull request Dec 12, 2025

Tweak rule based sampler open-telemetry/opentelemetry-configuration#461

Open

jack-berg mentioned this pull request Dec 12, 2025

ExperimentalComposableRuleBasedSamplerRule should support matching on multiple attributes open-telemetry/opentelemetry-configuration#464

Open

jack-berg approved these changes Dec 18, 2025

View reviewed changes

jack-berg changed the title ~~Update to latest unreleased opentelemetry-configuration~~ Update to opentelemetry-configuration 1.0.0-rc.3 Dec 18, 2025

anuraaga commented Dec 19, 2025

View reviewed changes

Fix exporter factory, resource detector factory validation

bc11574

jack-berg merged commit 44af6c6 into open-telemetry:main Dec 19, 2025
27 checks passed

Update to opentelemetry-configuration 1.0.0-rc.3 #7861

Update to opentelemetry-configuration 1.0.0-rc.3 #7861

Uh oh!

Conversation

anuraaga commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zeitlinger commented Nov 20, 2025

Uh oh!

anuraaga commented Nov 20, 2025

Uh oh!

zeitlinger commented Nov 20, 2025

Uh oh!

anuraaga commented Nov 21, 2025

Uh oh!

zeitlinger commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jack-berg commented Dec 18, 2025

Uh oh!

jkwatson commented Dec 18, 2025

Uh oh!

anuraaga left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

otelbot bot commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anuraaga commented Nov 20, 2025 •

edited

Loading

codecov bot commented Nov 20, 2025 •

edited

Loading