Skip to content

Conversation

@SylvainJuge
Copy link
Contributor

The value is not stored nor tested in the AttributePredicate, even if this works with the test below having it hardcoded is probably a refactor leftover.

@SylvainJuge SylvainJuge requested a review from a team as a code owner December 19, 2025 16:45
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (23799f2) to head (23ecd1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7932   +/-   ##
=========================================
  Coverage     90.12%   90.12%           
  Complexity     7411     7411           
=========================================
  Files           833      833           
  Lines         22396    22396           
  Branches       2200     2200           
=========================================
  Hits          20185    20185           
  Misses         1518     1518           
  Partials        693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 53b54cc into open-telemetry:main Dec 19, 2025
27 checks passed
@SylvainJuge SylvainJuge deleted the minor-fix-sampler branch December 19, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants