HTTP semantic convention stability migration for Tornado #3993
+755
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
JWinermaSplunk
approved these changes
Dec 4, 2025
xrmx
reviewed
Dec 22, 2025
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Outdated
Show resolved
Hide resolved
…telemetry/instrumentation/tornado/__init__.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…telemetry/instrumentation/tornado/__init__.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
xrmx
reviewed
Dec 24, 2025
| Note that the patch does not apply on every single __init__ call, only the first one for the entire | ||
| process lifetime. | ||
| """ | ||
| global _sem_conv_opt_in_mode # pylint: disable=global-statement |
Contributor
There was a problem hiding this comment.
Do you think we can make this an attribute of TornadoInstrumentor instead of being global?
| if handler.request.path: | ||
| # Parse query from path if present | ||
| path = handler.request.path | ||
| if "?" in path: |
Contributor
There was a problem hiding this comment.
I'd use urllib.parse.urlparse instead of doing things manually
| HTTP_TARGET: request.path, | ||
| } | ||
| # Add target (path) for active requests | ||
| if request.path: |
Contributor
There was a problem hiding this comment.
Are there cases where this is falsy?
| return | ||
| start_time = otel_handler_state.get(_START_TIME, None) or default_timer() | ||
| elapsed_time = round((default_timer() - start_time) * 1000) | ||
| elapsed_time_ms = round((default_timer() - start_time) * 1000) |
Contributor
There was a problem hiding this comment.
If you calculate the elapsed_time_s first we can reuse that and then have the same value :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds HTTP semantic convention stability migration / opt-in for
opentelemetry-instrumentation-tornadoRemoves
reason,description, andStatusbecause opt-in util_set_statusdoesn't accept them. Changes the signatures of several helpers not used by other instrumentors:_create_client_histograms,_create_server_histograms,_get_attributes_from_request.Fixes #3991
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Default span attributes
httpspan attributeshttp/duphas both sets.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.