Skip to content

Conversation

@herin049
Copy link
Contributor

Description

Updates AwsXRayIdGenerator to define is_trace_id_random() to return True and update unit tests for core changes to add support for populating the random-trace-id flags in the W3C traceparent header based on the W3C trace context specification: https://www.w3.org/TR/trace-context-2/#random-trace-id-flag

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been updated to handle additional header flag.

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, the title and CHANGELOG mention only xray but you're touching another half dozen instrumentations

@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

7 participants