refactor(asgi): replace HTTP_SERVER_NAME SpanAttribute with semconv attribute #4039
+34
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Dec 17, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
I think there are a lot more users of SpanAttributes in the asgi package
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
…emetry/instrumentation/asgi/__init__.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…emetry/instrumentation/asgi/__init__.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Author
|
@xrmx kindly look into the changes as per convenience if the following PR is merge ready, thank you. |
Contributor
As I already mentioned there are a ton more of users of SpanAttributes in the asgi instrumentation, i.e. |
xrmx
reviewed
Dec 23, 2025
| "name": "GET / http send", | ||
| "kind": trace_api.SpanKind.INTERNAL, | ||
| "attributes": { | ||
| SpanAttributes.HTTP_STATUS_CODE: 200, |
Contributor
There was a problem hiding this comment.
The task is to substitute the use of SpanAttributes with other modules inside opentelemetry.semconv, not to change what is asserted here. If we don't have a replacement with the same value then they should stay untouched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3475
Type of change
How Has This Been Tested?
This change updates a semantic convention attribute constant without modifying
runtime behavior. Local test execution on Windows is limited by environment
constraints; CI will validate the change.
Does This PR Require a Core Repo Change?
Checklist: