Skip to content

Conversation

@herin049
Copy link
Contributor

@herin049 herin049 commented Dec 22, 2025

Description

This PR adds the ability to capture custom client headers in the opentelemetry-instrumentation-httpx library. These changes implement #3962 for the httpx HTTP client library.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Basic set of unit tests have been added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@herin049 herin049 requested a review from a team as a code owner December 22, 2025 19:58
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Dec 23, 2025
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but LGTM

span: Span,
status_code: int,
http_version: str,
headers: httpx.Headers | dict[str, list[str] | str] | None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move optional params after semconv that is mandatory

metric_attributes: dict[str, typing.Any],
url: str | httpx.URL,
method_original: str,
headers: httpx.Headers | dict[str, list[str] | str] | None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move optional params after semconv that is mandatory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants