Skip to content

Conversation

@DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Dec 12, 2025

Open l10n drop. Files have been updated with translated versions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373119: JDK 26 RDP1 L10n resource files update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28802/head:pull/28802
$ git checkout pull/28802

Update a local copy of the PR:
$ git checkout pull/28802
$ git pull https://git.openjdk.org/jdk.git pull/28802/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28802

View PR using the GUI difftool:
$ git pr show -t 28802

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28802.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2025

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373119: JDK 26 RDP1 L10n resource files update

Reviewed-by: jlu, asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

invalid.null.action.provided=Ungültige Nullaktion angegeben
invalid.null.Class.provided=Ungültige Nullklasse angegeben
Subject.=Subjekt:\n
Subject.=Subject:\n
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change reverts what was previously changed in the last l10n drop. There was a request to change word "Subject" to "Subjekt" at the time, and this was manually adjusted. This issue was brought up to the translation team but was ultimately rejected. So, to align with upstream, I will leave this as is.

doclet.search_in_documentation=In Dokumentation suchen
doclet.search_reset=Zurücksetzen
doclet.Member=Mitglied
doclet.Member=Member
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above with security.properties, this change was brought up to the localization team and rejected. I intend to keep this as is for the same reason.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@DamonGuy The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • javadoc
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@DamonGuy DamonGuy marked this pull request as ready for review December 12, 2025 21:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2025

Webrevs

Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified some errors/inconsistencies you might bring to the translation team.

@alexeysemenyukoracle
Copy link
Member

jpackage changes look good: all keys are in place and translated. Can't comment on translations, though. I don't speak any of these languages.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2025
Copy link
Contributor

@slowhog slowhog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jlink changes for zh_CN looks good to me.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 15, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 15, 2025
Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you addressed the concerns that were possible to resolve, and will file the rest with the translation team. LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org javadoc javadoc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

8 participants