-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373119: JDK 26 RDP1 L10n resource files update #28802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties
Outdated
Show resolved
Hide resolved
|
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| invalid.null.action.provided=Ungültige Nullaktion angegeben | ||
| invalid.null.Class.provided=Ungültige Nullklasse angegeben | ||
| Subject.=Subjekt:\n | ||
| Subject.=Subject:\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change reverts what was previously changed in the last l10n drop. There was a request to change word "Subject" to "Subjekt" at the time, and this was manually adjusted. This issue was brought up to the translation team but was ultimately rejected. So, to align with upstream, I will leave this as is.
| doclet.search_in_documentation=In Dokumentation suchen | ||
| doclet.search_reset=Zurücksetzen | ||
| doclet.Member=Mitglied | ||
| doclet.Member=Member |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above with security.properties, this change was brought up to the localization team and rejected. I intend to keep this as is for the same reason.
|
@DamonGuy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
justin-curtis-lu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identified some errors/inconsistencies you might bring to the translation team.
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties
Show resolved
Hide resolved
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_de.properties
Show resolved
Hide resolved
src/java.base/share/classes/sun/launcher/resources/launcher_zh_CN.properties
Outdated
Show resolved
Hide resolved
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
Show resolved
Hide resolved
...avadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
Show resolved
Hide resolved
|
jpackage changes look good: all keys are in place and translated. Can't comment on translations, though. I don't speak any of these languages. |
slowhog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jlink changes for zh_CN looks good to me.
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
Show resolved
Hide resolved
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
Show resolved
Hide resolved
src/java.base/share/classes/sun/launcher/resources/launcher_zh_CN.properties
Outdated
Show resolved
Hide resolved
justin-curtis-lu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you addressed the concerns that were possible to resolve, and will file the rest with the translation team. LGTM.
Open l10n drop. Files have been updated with translated versions.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28802/head:pull/28802$ git checkout pull/28802Update a local copy of the PR:
$ git checkout pull/28802$ git pull https://git.openjdk.org/jdk.git pull/28802/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28802View PR using the GUI difftool:
$ git pr show -t 28802Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28802.diff
Using Webrev
Link to Webrev Comment