6562639: Wrong pixel bounds from TextLayout with white font #28809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the possible code paths for
TextLayout.getPixelBounds(...)actually draws the text on aGraphics2Dand checks the image pixels afterwards. The text is drawn over a white background, so if the user sets the font's foreground color to white then the text pixels cannot be detected (white on white).This PR fixes the issue by removing the code that sets the background to white, leaving the background as the default ARGB color (0 = transparent black). This does not cause a new problem for users who might set their font foreground color to transparent black, because transparent font foreground colors always return an empty bounds anyway (by virtue of being transparent).
The updated code should also be slightly faster since it's doing less work, though I haven't run any performance tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28809/head:pull/28809$ git checkout pull/28809Update a local copy of the PR:
$ git checkout pull/28809$ git pull https://git.openjdk.org/jdk.git pull/28809/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28809View PR using the GUI difftool:
$ git pr show -t 28809Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28809.diff
Using Webrev
Link to Webrev Comment