Skip to content

Conversation

@gredler
Copy link
Contributor

@gredler gredler commented Dec 13, 2025

One of the possible code paths for TextLayout.getPixelBounds(...) actually draws the text on a Graphics2D and checks the image pixels afterwards. The text is drawn over a white background, so if the user sets the font's foreground color to white then the text pixels cannot be detected (white on white).

This PR fixes the issue by removing the code that sets the background to white, leaving the background as the default ARGB color (0 = transparent black). This does not cause a new problem for users who might set their font foreground color to transparent black, because transparent font foreground colors always return an empty bounds anyway (by virtue of being transparent).

The updated code should also be slightly faster since it's doing less work, though I haven't run any performance tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6562639: Wrong pixel bounds from TextLayout with white font (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28809/head:pull/28809
$ git checkout pull/28809

Update a local copy of the PR:
$ git checkout pull/28809
$ git pull https://git.openjdk.org/jdk.git pull/28809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28809

View PR using the GUI difftool:
$ git pr show -t 28809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28809.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2025

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 13, 2025
@openjdk
Copy link

openjdk bot commented Dec 13, 2025

@gredler The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant