-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2484: Replacing SiteConfig with ClusterInstance #103872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@rohennes: This pull request references TELCODOCS-2484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@rohennes: This pull request references TELCODOCS-2484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
335ebb9 to
8199473
Compare
|
@rohennes: This pull request references TELCODOCS-2484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8199473 to
c88cfd2
Compare
| @@ -1,6 +1,6 @@ | |||
| :_mod-docs-content-type: ASSEMBLY | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
| .Additional resources | ||
|
|
||
| * For information about removing a cluster, see link:https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.9/html/clusters/cluster_mce_overview#remove-managed-cluster[Removing a cluster from management]. | ||
| * link:https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.9/html/clusters/cluster_mce_overview#remove-managed-cluster[Removing a cluster from management]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.RelatedLinks: Content other than links cannot be mapped to DITA related-links.
| @@ -0,0 +1,203 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
| generatorOptions: | ||
| disableNameSuffixHash: true <2> | ||
| ---- | ||
| <1> The namespace must match the `ClusterInstance` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| - name: ipsec-manifests-cm <1> | ||
| # ... | ||
| ---- | ||
| <1> Reference to the `ConfigMap` containing the IPsec certificate import manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| generatorOptions: | ||
| disableNameSuffixHash: true <2> | ||
| ---- | ||
| <1> The namespace must match the `ClusterInstance` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| - name: ipsec-manifests-cm <1> | ||
| # ... | ||
| ---- | ||
| <1> Reference to the `ConfigMap` containing the IPsec manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| generatorOptions: | ||
| disableNameSuffixHash: true | ||
| ---- | ||
| <1> The name of the `ClusterInstance` CR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| namespace: example-cluster | ||
| # ... | ||
| ---- | ||
| <1> Reference to the `ConfigMap` CR that contains the custom `InfraEnv` CR template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| type: kubernetes.io/dockerconfigjson | ||
| ---- | ||
| <1> Must match the namespace configured in the related `SiteConfig` CR | ||
| <1> Must match the namespace configured in the related `ClusterInstance` CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| ==== | ||
| Where possible, use a single `SiteConfig` CR per cluster. | ||
| ==== | ||
| <1> The namespace must match the `ClusterInstance` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| # ... | ||
| ---- | ||
| <1> Applies to all hosts in the `cluster-1` cluster | ||
| <1> Applies the firmware profile to all hosts in the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| # ... | ||
| ---- | ||
| <1> Applies the firmware profile to the `compute-1.example.com` host in the cluster | ||
| <1> Applies the firmware profile only to the `node1.example.com` host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
| . Create ConfigMaps from the manifest directories and reference them in the `ClusterInstance` CR using the `extraManifestsRefs` field. | ||
| + | ||
| .Example SiteConfig CR | ||
| .Example kustomization.yaml with configMapGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
| generatorOptions: | ||
| disableNameSuffixHash: true | ||
| ---- | ||
| <1> Extra manifest files from the `ztp-site-generate` container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
|
|
||
| . Edit the `ClusterInstance` CR to reference the `ConfigMap` CR: | ||
| + | ||
| .Example ClusterInstance CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
| ---- | ||
| <1> The directory containing the reference manifests must be listed first under `extraManifests.searchPaths`. | ||
| <2> If you are using user-provided CRs, the last directory listed under `extraManifests.searchPaths` in the `SiteConfig` CR must be the directory containing those user-provided CRs. | ||
| <1> Reference the ConfigMap containing the extra manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
c88cfd2 to
5752f6e
Compare
|
@rohennes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
TELCODOCS-2484: Replacing SiteConfig with ClusterInstance
Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/TELCODOCS-2484
Link to docs preview:
https://103872--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-deploying-far-edge-sites.html
QE review:
Additional information: