[3/n] [reconfigurator-sim] add an operation log #9365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.3n-reconfigurator-cli-add-an-operation-log
to
main
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Dec 9, 2025
| /// | ||
| /// Clears all operation history and resets to just the root operation. | ||
| /// This is the only operation that violates the append-only principle. | ||
| Wipe, |
Contributor
There was a problem hiding this comment.
Just checking my understanding: Is the difference between op wipe and wipe {system,all} that the latter two are themselves operations appended to the log (that wipe the simulated state but can be undone/redone), and the former erases the log itself?
Contributor
Author
There was a problem hiding this comment.
Correct, yeah. The operation log is the root of everything so this is a higher-level wipe.
| } | ||
|
|
||
| // Invariant: the ID should be not present in the store, having been | ||
| // generated by next_sim_uuid. |
Contributor
There was a problem hiding this comment.
This is still required, right?
Contributor
Author
There was a problem hiding this comment.
Ah yeah, good catch.
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/3n-reconfigurator-cli-add-an-operation-log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an operation log to the simulator, as well as ways to undo, redo and restore to the last operation. Modeled pretty directly after how Jujutsu's operation log works.
The biggest change here is that the current pointer is now managed by the simulator rather than reconfigurator-cli, so that it can be versioned as part of the operation.
Depends on: