[sled-agent-types] move functional code to impls module #9514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Dec 14, 2025
Comment on lines
+165
to
+167
| /// | ||
| /// TODO: The serde deserializer does not currently verify uniqueness of | ||
| /// dimensions. |
Contributor
Author
There was a problem hiding this comment.
@smklein fyi -- worth fixing in the future for sure
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Dec 16, 2025
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
I like this a lot more than the earlier extension trait pattern (even as a fan of extension traits in general).
sunshowers
deleted the
sunshowers/spr/sled-agent-types-move-functional-code-back-to-types-crate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9488 we moved versioned Sled Agent types to the sled-agent-types-versions crate. In that PR we moved functional code into that crate as well, living in the same files as types. However, dealing with updating this code can easily go wrong, particularly around merge conflicts.
Move this kind of functional code to an
implsmodule, so that it is always implemented on the latest versions of types.