Skip to content

CLN: remove ignoring bad-param-name-override of pyrefly from pyproject.toml #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loicdiridollou merged 3 commits into from
Dec 7, 2025
Merged

CLN: remove ignoring bad-param-name-override of pyrefly from pyproject.toml #1527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
529984d
remove ignoring bad-param-name-override
cmp0xff Dec 4, 2025
d71f9ab
https://github.com/pandas-dev/pandas-stubs/pull/1527#discussion_r2590…
cmp0xff Dec 4, 2025
7136d16
onemissing case
cmp0xff Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas-stubs/_libs/missing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class NAType:
@overload
def __eq__(self, other: Index, /) -> BooleanArray: ...
@overload
def __eq__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __eq__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: Scalar, /
) -> NAType: ...
@overload # type: ignore[override]
Expand All @@ -127,7 +127,7 @@ class NAType:
@overload
def __ne__(self, other: Index, /) -> BooleanArray: ...
@overload
def __ne__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __ne__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: Scalar, /
) -> NAType: ...
@overload
Expand Down
6 changes: 3 additions & 3 deletions pandas-stubs/_libs/tslibs/offsets.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class BaseOffset:
self, other: np_ndarray[ShapeT, np.object_]
) -> np_ndarray[ShapeT, np.object_]: ...
@overload
def __add__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
def __add__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __add__(self, other: date) -> Timestamp: ...
@overload
Expand All @@ -57,7 +57,7 @@ class BaseOffset:
self, other: np_ndarray[ShapeT, np.object_]
) -> np_ndarray[ShapeT, np.object_]: ...
@overload
def __radd__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
def __radd__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __radd__(self, other: date) -> Timestamp: ...
@overload
Expand All @@ -68,7 +68,7 @@ class BaseOffset:
@overload
def __rsub__(self, other: npt.NDArray[np.object_]) -> npt.NDArray[np.object_]: ...
@overload
def __rsub__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
def __rsub__(self, other: _DatetimeT) -> _DatetimeT: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __rsub__(self, other: date) -> Timestamp: ...
@overload
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/_libs/tslibs/timestamps.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class Timestamp(datetime, SupportsIndex):
def fold(self) -> int: ...
if sys.version_info >= (3, 12):
@classmethod
def fromtimestamp( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def fromtimestamp( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override] # pyrefly: ignore[bad-param-name-override]
cls, t: float, tz: _tzinfo | str | None = ...
) -> Self: ...
else:
Expand Down
7 changes: 4 additions & 3 deletions pandas-stubs/core/arrays/categorical.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,12 @@ class Categorical(ExtensionArray):
) -> Categorical: ...
def __contains__(self, item) -> bool: ...
@overload
def __getitem__(self, key: ScalarIndexer) -> Any: ...
def __getitem__( # pyrefly: ignore[bad-override]
self, item: ScalarIndexer
) -> Any: ...
@overload
def __getitem__( # ty: ignore[invalid-method-override]
self,
key: SequenceIndexer | PositionalIndexerTuple,
self, key: SequenceIndexer | PositionalIndexerTuple
) -> Self: ...
def __setitem__(self, key, value) -> None: ...
def min(self, *, skipna: bool = ...): ...
Expand Down
5 changes: 2 additions & 3 deletions pandas-stubs/core/arrays/datetimelike.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@ class DatetimeLikeArrayMixin(ExtensionOpsMixin, ExtensionArray):
@property
def size(self) -> int: ...
@overload
def __getitem__(self, key: ScalarIndexer) -> DTScalarOrNaT: ...
def __getitem__(self, item: ScalarIndexer) -> DTScalarOrNaT: ...
Copy link
Member

@loicdiridollou loicdiridollou Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here? I think pandas code has key and not item. Same in a few other places, not sure item is used that much in the pandas code.

Copy link
Contributor Author

@cmp0xff cmp0xff Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! The motivation was to keep pyrefly happy, which requires the param name identical to the one in the base class. But I believe we should really keep them identical to the one in pandas in the concrete implementation, which do not necessarily follow the pyrefly rule.

Incidently, in pandas there are overloads of the concrete implementation which have different param names than the ones in the concrete implementation. I've chosen to follow the concrete implementation.

d71f9ab

Copy link
Contributor Author

@cmp0xff cmp0xff Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I have the following example:

from typing import overload


@overload
def foo(x: int) -> int: ...

@overload
def foo(x: str) -> str: ...

def foo(z: int | str):
    return z

foo(x=1)  # passes type check at this line, but fails at runtime

This is the implementation in DatetimeLikeArrayMixin.__getitem__ in 2.3.3. in main of pandas they have been made identical.

Copy link
Collaborator

@Dr-Irv Dr-Irv Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! The motivation was to keep pyrefly happy, which requires the param name identical to the one in the base class. But I believe we should really keep them identical to the one in pandas in the concrete implementation, which do not necessarily follow the pyrefly rule.

Incidently, in pandas there are overloads of the concrete implementation which have different param names than the ones in the concrete implementation. I've chosen to follow the concrete implementation.

I think the rule of thumb here that is equivalent is that the names we use in the stubs should also correspond to what is in the documentation, which I believe are also the names in the concrete implementation.

Copy link
Member

@loicdiridollou loicdiridollou Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the argument name as key in the code:
https://github.com/pandas-dev/pandas/blob/fa1360d41a49173ddfc676c8194ca424871338c8/pandas/core/arrays/datetimelike.py#L376-L385

@overload
def __getitem__( # ty: ignore[invalid-method-override]
self,
item: SequenceIndexer | PositionalIndexerTuple,
self, item: SequenceIndexer | PositionalIndexerTuple
) -> Self: ...
def __setitem__( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
self, key: int | Sequence[int] | Sequence[bool] | slice, value
Expand Down
5 changes: 2 additions & 3 deletions pandas-stubs/core/arrays/sparse/array.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,10 @@ class SparseArray(ExtensionArray, ExtensionOpsMixin):
def unique(self): ...
def value_counts(self, dropna: bool = True): ...
@overload
def __getitem__(self, key: ScalarIndexer) -> Any: ...
def __getitem__(self, item: ScalarIndexer) -> Any: ...
@overload
def __getitem__( # ty: ignore[invalid-method-override]
self,
item: SequenceIndexer | tuple[int | ellipsis, ...],
self, item: SequenceIndexer | tuple[int | ellipsis, ...]
) -> Self: ...
def copy(self): ...
def map(self, mapper): ...
Expand Down
9 changes: 4 additions & 5 deletions pandas-stubs/core/groupby/generic.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class SeriesGroupBy(GroupBy[Series[S2]], Generic[S2, ByT]):
# Overrides that provide more precise return types over the GroupBy class
@final # type: ignore[misc]
# pyrefly: ignore # bad-override
def __iter__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[override-of-final-method]
def __iter__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[override-of-final-method]
self,
) -> Iterator[tuple[ByT, Series[S2]]]: ...

Expand Down Expand Up @@ -297,7 +297,7 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
@overload
def __getitem__(self, key: Scalar) -> SeriesGroupBy[Any, ByT]: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, key: Iterable[Hashable]
) -> DataFrameGroupBy[ByT, _TT]: ...
def nunique(self, dropna: bool = True) -> DataFrame: ...
Expand Down Expand Up @@ -450,12 +450,11 @@ class DataFrameGroupBy(GroupBy[DataFrame], Generic[ByT, _TT]):
@property
def dtypes(self) -> Series: ...
def __getattr__(
self, name: str
self, attr: str
) -> SeriesGroupBy[Any, ByT]: ... # ty: ignore[invalid-method-override]
# Overrides that provide more precise return types over the GroupBy class
@final # type: ignore[misc]
# pyrefly: ignore # bad-override
def __iter__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[override-of-final-method]
def __iter__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[override-of-final-method] # pyrefly: ignore[bad-override]
self,
) -> Iterator[tuple[ByT, DataFrame]]: ...
@overload
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/core/indexes/base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ FloatNotNumpy16DtypeArg: TypeAlias = (
class InvalidIndexError(Exception): ...

class Index(IndexOpsMixin[S1], ElementOpsMixin[S1]):
__hash__: ClassVar[None] # type: ignore[assignment] # pyright: ignore[reportIncompatibleMethodOverride]
__hash__: ClassVar[None] # type: ignore[assignment] # pyright: ignore[reportIncompatibleMethodOverride]
# overloads with additional dtypes
@overload
def __new__( # pyright: ignore[reportOverlappingOverload]
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/core/indexes/datetimes.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DatetimeIndex(
self, other: datetime | np.datetime64 | np_ndarray_dt | Self
) -> TimedeltaIndex: ...
@overload
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: timedelta | np.timedelta64 | np_ndarray_td | BaseOffset
) -> Self: ...
def __truediv__( # type: ignore[override] # pyrefly: ignore[bad-override]
Expand Down
14 changes: 7 additions & 7 deletions pandas-stubs/core/indexes/interval.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,55 +237,55 @@ class IntervalIndex(ExtensionIndex[IntervalT, np.object_], IntervalMixin):
),
) -> IntervalIndex[IntervalT]: ...
@overload
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, idx: int
) -> IntervalT: ...
@overload # type: ignore[override]
def __gt__(
self, other: IntervalT | IntervalIndex[IntervalT]
) -> np_1darray_bool: ...
@overload
def __gt__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __gt__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: pd.Series[IntervalT]
) -> pd.Series[bool]: ...
@overload # type: ignore[override]
def __ge__(
self, other: IntervalT | IntervalIndex[IntervalT]
) -> np_1darray_bool: ...
@overload
def __ge__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __ge__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: pd.Series[IntervalT]
) -> pd.Series[bool]: ...
@overload # type: ignore[override]
def __le__(
self, other: IntervalT | IntervalIndex[IntervalT]
) -> np_1darray_bool: ...
@overload
def __le__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __le__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: pd.Series[IntervalT]
) -> pd.Series[bool]: ...
@overload # type: ignore[override]
def __lt__(
self, other: IntervalT | IntervalIndex[IntervalT]
) -> np_1darray_bool: ...
@overload
def __lt__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __lt__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: pd.Series[IntervalT]
) -> pd.Series[bool]: ...
@overload # type: ignore[override]
def __eq__(self, other: IntervalT | IntervalIndex[IntervalT]) -> np_1darray_bool: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __eq__(self, other: pd.Series[IntervalT]) -> pd.Series[bool]: ... # type: ignore[overload-overlap]
@overload
def __eq__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __eq__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: object
) -> Literal[False]: ...
@overload # type: ignore[override]
def __ne__(self, other: IntervalT | IntervalIndex[IntervalT]) -> np_1darray_bool: ... # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
@overload
def __ne__(self, other: pd.Series[IntervalT]) -> pd.Series[bool]: ... # type: ignore[overload-overlap]
@overload
def __ne__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __ne__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: object
) -> Literal[True]: ...

Expand Down
8 changes: 4 additions & 4 deletions pandas-stubs/core/indexes/multi.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class MultiIndex(Index):
@property
def codes(self): ...
def set_codes(self, codes, *, level=..., verify_integrity: bool = ...): ...
def copy( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride] # pyrefly: ignore
def copy( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride] # pyrefly: ignore
self, names: SequenceNotStr[Hashable] = ..., deep: bool = False
) -> Self: ...
def view(self, cls=...): ...
Expand Down Expand Up @@ -113,7 +113,7 @@ class MultiIndex(Index):
def droplevel(self, level: Level | Sequence[Level] = 0) -> MultiIndex | Index: ... # type: ignore[override]
def get_level_values(self, level: str | int) -> Index: ...
def unique(self, level=...): ...
def to_frame( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
def to_frame( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
self,
index: bool = True,
name: list[HashableT] = ...,
Expand All @@ -133,7 +133,7 @@ class MultiIndex(Index):
idx: slice | np_ndarray_anyint | Sequence[int] | Index | MaskType,
) -> Self: ...
@overload
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, key: int
) -> tuple: ...
def append(self, other): ...
Expand Down Expand Up @@ -171,7 +171,7 @@ class MultiIndex(Index):
self, values: Iterable[Any], level: Level
) -> np_1darray_bool: ...
@overload
def isin( # ty: ignore[invalid-method-override] # pyright: ignore[reportIncompatibleMethodOverride]
def isin( # ty: ignore[invalid-method-override] # pyright: ignore[reportIncompatibleMethodOverride]
self, values: Collection[Iterable[Any]], level: None = None
) -> np_1darray_bool: ...
def set_names(
Expand Down
4 changes: 2 additions & 2 deletions pandas-stubs/core/indexes/period.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period, np.object_], PeriodIndexField
@overload
def __sub__(self, other: NaTType) -> NaTType: ...
@overload
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __sub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: TimedeltaIndex | pd.Timedelta
) -> Self: ...
@overload # type: ignore[override]
Expand All @@ -63,7 +63,7 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period, np.object_], PeriodIndexField
@overload
def __rsub__(self, other: Self) -> Index: ...
@overload
def __rsub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __rsub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: NaTType
) -> NaTType: ...
def asof_locs(
Expand Down
2 changes: 1 addition & 1 deletion pandas-stubs/core/indexes/range.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class RangeIndex(_IndexSubclassBase[int, np.int64]):
idx: slice | np_ndarray_anyint | Sequence[int] | Index | MaskType,
) -> Index: ...
@overload
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, idx: int
) -> int: ...
def where( # type: ignore[override]
Expand Down
14 changes: 7 additions & 7 deletions pandas-stubs/core/indexes/timedeltas.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class TimedeltaIndex(
@overload
def __add__(self, other: datetime | DatetimeIndex) -> DatetimeIndex: ...
@overload
def __add__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __add__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: timedelta | Self
) -> Self: ...
@overload # type: ignore[override]
Expand All @@ -83,7 +83,7 @@ class TimedeltaIndex(
@overload
def __radd__(self, other: datetime | DatetimeIndex) -> DatetimeIndex: ...
@overload
def __radd__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __radd__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: timedelta | Self
) -> Self: ...
def __sub__( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
Expand All @@ -95,7 +95,7 @@ class TimedeltaIndex(
self, other: timedelta | np.timedelta64 | np_ndarray_td | BaseOffset | Self
) -> Self: ...
@overload
def __rsub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __rsub__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: datetime | np.datetime64 | np_ndarray_dt | DatetimeIndex
) -> DatetimeIndex: ...
@overload # type: ignore[override]
Expand All @@ -121,15 +121,15 @@ class TimedeltaIndex(
@overload
def __truediv__(self, other: _NUM_FACTOR_SEQ) -> Self: ...
@overload
def __truediv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __truediv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: _DT_FACTOR_SEQ | Self
) -> Index[float]: ...
@overload # type: ignore[override]
def __rtruediv__( # pyrefly: ignore[bad-override]
self, other: np_ndarray_bool | np_ndarray_complex | np_ndarray_dt
) -> Never: ...
@overload
def __rtruediv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __rtruediv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: _DT_FACTOR_SEQ | Self
) -> Index[float]: ...
@overload # type: ignore[override]
Expand All @@ -139,15 +139,15 @@ class TimedeltaIndex(
@overload
def __floordiv__(self, other: _NUM_FACTOR_SEQ) -> Self: ...
@overload
def __floordiv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __floordiv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: _DT_FACTOR_SEQ | Self
) -> Index[int]: ...
@overload
def __rfloordiv__( # pyrefly: ignore[bad-override]
self, other: np_ndarray_num | np_ndarray_dt
) -> Never: ...
@overload
def __rfloordiv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
def __rfloordiv__( # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
self, other: _DT_FACTOR_SEQ | Self
) -> Index[int]: ...
@property
Expand Down
4 changes: 2 additions & 2 deletions pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ class Series(IndexOpsMixin[S1], ElementOpsMixin[S1], NDFrame):
copy: bool | None = None,
) -> Series[Interval[_OrderableT]]: ...
@overload
def __new__( # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
def __new__( # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
cls,
data: Scalar | _DataLike | dict[HashableT1, Any] | None,
index: AxesData | None = None,
Expand Down Expand Up @@ -4652,7 +4652,7 @@ class Series(IndexOpsMixin[S1], ElementOpsMixin[S1], NDFrame):
copy: _bool | _NoDefaultDoNotUse = ...,
) -> Self: ...
@final
def xs( # pyright: ignore[reportIncompatibleMethodOverride] # pyrefly: ignore[bad-override] # ty: ignore[invalid-method-override]
def xs( # pyright: ignore[reportIncompatibleMethodOverride] # pyrefly: ignore[bad-override] # ty: ignore[invalid-method-override]
self,
key: Hashable,
axis: AxisIndex = 0, # type: ignore[override]
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,6 @@ reportPrivateUsage = false
reportMissingModuleSource = true
useLibraryCodeForTypes = false

[tool.pyrefly.errors]
bad-param-name-override = false # TODO: report to pyrefly https://github.com/pandas-dev/pandas-stubs/pull/1412#pullrequestreview-3310645279

[tool.codespell]
ignore-words-list = "indext, mose, sav, ser"

Expand Down
Loading