REGR: Fix IntervalArray.nunique with infinity #63267
Merged
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Regression
mroeschke
approved these changes
Dec 4, 2025
pandas/core/arrays/interval.py
Outdated
| comb = (np.array(left.ravel(), dtype="complex128")) + ( | ||
| 1j * np.array(right.ravel(), dtype="complex128") | ||
| ) | ||
| comb = np.array(left.ravel(), dtype="complex128") |
Member
There was a problem hiding this comment.
Could we use np.asarray? (NumPy might copy anyways but would be nice if it didn't in this case)
Member
Author
There was a problem hiding this comment.
Updated, but I believe it always makes a copy when going float64 -> complex128. I also tried
comb = np.empty(left.shape, dtype="complex128")
comb.real = left
comb.imag = rightbut that had slightly worse performance than the identical np.array and np.asarray.
Member
|
Thanks @rhshadrach |
Contributor
|
Thanks @rhshadrach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.No whatsnew as this regression was introduced as part of 3.0 development.
The issue is multiplication with complex numbers and infinities can be surprising:
The NaN comes from
infbeing interpreted asinf + 0j. Then(inf + 0j) * (0 + 1j)makes the real part consist ofinf * 0 + 0j * 1jwithinf*0givingnan. We therefore need to avoid multiplication.