Skip to content

Conversation

@AKHIL-149
Copy link
Contributor

@AKHIL-149 AKHIL-149 commented Dec 7, 2025

I added the strict=True parameter to 2 zip() calls in pandas/tests/dtypes/test_inference.py to enforce Ruff rule B905.

Changes made:

  • Line 191: Added strict=True to zip(*ll_params, strict=True)
  • Line 194: Added strict=True to zip(objs, expected, strict=True) in the pytest fixture

This ensures that all zipped iterables have equal lengths, making the tests more robust by catching potential bugs early.


Checklist:

  • xref STY: Enforce Ruff rule B905, zip-without-explicit-strict #62434
  • Tests added and passed if fixing a bug or adding a new feature - N/A: This is a style fix, existing tests will validate the change
  • All code checks passed
  • Added type annotations to new arguments/methods/functions - N/A: No new code added
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature - N/A: Style fix doesn't require whatsnew entry
  • If I used AI to develop this pull request, I prompted it to follow AGENTS.md - N/A: Manual code changes

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Dec 8, 2025
@mroeschke mroeschke added this to the 3.0 milestone Dec 8, 2025
@mroeschke mroeschke merged commit 70d5c53 into pandas-dev:main Dec 8, 2025
46 checks passed
@mroeschke
Copy link
Member

Thanks @AKHIL-149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants