Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This plug-in will help you to choose and add the gitmoji, via a button in the Co
* Load the list of gitmoji on startup from the repos of gitmoji (fallback to a local list if error).
* Allow to display the gitmoji in a new column in the commit history
* Translate the gitmoji description in your chinese and french language.
* Custom gitmoji list from url or predefined default [Gitmojis](https://gitmoji.dev/) or [Conventional Gitmojis](https://conventional-gitmoji.web.app/)
* Custom gitmoji list from url or predefined default [Gitmojis](https://gitmoji.dev/) or [Conventional Gitmojis](https://ackeecz.github.io/conventional-gitmoji/)

See the [gitmoji website](https://gitmoji.dev/) for have the list of Emoji and their signification.
<!-- Plugin description end -->
Expand Down
2 changes: 1 addition & 1 deletion custom_gitmojis.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ The plugin will try to download remote YAML translations. If the network fetch o
- The plugin ships a bundled default file at [gitmojis.json](./src/main/resources/gitmojis.json). If an HTTP fetch of the configured JSON URL fails, the plugin falls back to this embedded file.
- Default localization example file can be found at [gitmojis.yaml](./src/main/resources/gitmojis.yaml).
- The default remote URL used by the plugin for Gitmoji source is https://gitmoji.dev/api/gitmojis
- There is also a built-in [Conventional Gitmoji](https://conventional-gitmoji.web.app/) option, which is reduced set of Gitmojis matching the [conventional commit](https://www.conventionalcommits.org) specification.
- There is also a built-in [Conventional Gitmoji](https://ackeecz.github.io/conventional-gitmoji/) option, which is reduced set of Gitmojis matching the [conventional commit](https://www.conventionalcommits.org) specification.


## Practical example — host custom JSON and YAML on GitHub
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ sealed interface GitmojiSourceType {
override val settingsName: String = "Gitmoji Conventional"
override val jsonUrl: String = "https://raw.githubusercontent.com/glazrtom/conventional-gitmoji-config/refs/heads/master/gitmojis.json"
override val localizationUrl: String = "https://raw.githubusercontent.com/glazrtom/conventional-gitmoji-config/refs/heads/master/localizations/gitmojis-{locale}.yaml"
override val tooltipUrl: String = "https://conventional-gitmoji.web.app/"
override val tooltipUrl: String = "https://ackeecz.github.io/conventional-gitmoji/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change is correct, for better maintainability and consistency with other parts of this file (like the Custom object), consider defining this URL and the other related URLs (jsonUrl, localizationUrl) as const val in a companion object within ConventionalGitmoji. This would centralize the URLs and make them easier to manage.

override val tooltipText: String = GitmojiBundle.message("config.source.type.conventionalGitmoji.tooltip")
}

Expand Down