Skip to content

fix: update routing configuration to use PHP files for WebProfilerBundle #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbu merged 3 commits into from
Dec 8, 2025
Merged

fix: update routing configuration to use PHP files for WebProfilerBundle #481

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c99b7
fix: update routing configuration to use PHP files for WebProfilerBundle
ip512 Dec 6, 2025
5e533d3
bump symfony http-client version to oldest 7.x supported version
ip512 Dec 6, 2025
420d3ec
add note when we can remove this BC hack again
dbu Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ jobs:
symfony-require: "6.4.*"
php-version: "8.2"
symfony-deprecations-helper: "weak"
- dependencies: "php-http/guzzle7-adapter symfony/http-client:^7.1"
symfony-require: "7.1.*"
- dependencies: "php-http/guzzle7-adapter symfony/http-client:^7.3"
symfony-require: "7.3.*"
php-version: "8.2"
symfony-deprecations-helper: "weak"

Expand Down
5 changes: 3 additions & 2 deletions tests/Resources/app/AppKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ public function loadRoutes(LoaderInterface $loader): RouteCollection
$collection->add('/', new Route('/', ['_controller' => 'kernel::indexAction']));

$routes = new RoutingConfigurator($collection, $kernelLoader, $file, $file);
$routes->import('@WebProfilerBundle/Resources/config/routing/wdt.xml')->prefix('_wdt');
$routes->import('@WebProfilerBundle/Resources/config/routing/profiler.xml')->prefix('_profiler');
$extension = self::MAJOR_VERSION >= 7 ? 'php' : 'xml';
$routes->import('@WebProfilerBundle/Resources/config/routing/wdt.'.$extension)->prefix('_wdt');
$routes->import('@WebProfilerBundle/Resources/config/routing/profiler.'.$extension)->prefix('_profiler');

return $collection;
}
Expand Down