Render feature comparisons with standard function #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Preview for commit cf80cca can be found at https://web-php-pr-1612.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit cf80cca is at https://web-php-regression-report-pr-1612.preview.thephp.foundation |
theodorejb
force-pushed
the
feature-comparisons-function
branch
from
d667638 to
f5f8013
Compare
This refactor greatly simplifies maintaining consistent styling and markup for the feature comparisons. No content has been changed, except for fixing unnecessary blank lines at the start & end of the "Command line linter supports multiple files" code blocks on the PHP 8.3 release page.
theodorejb
force-pushed
the
feature-comparisons-function
branch
from
f5f8013 to
0aa67ea
Compare
Member
|
Is this still relevant, as the PHP 8.5 (and I suppose later) release announcements don't use this any more, and the existing ones are supposed to be static? |
Contributor
Author
|
It simplifies maintaining the pages in a consistent way. If we want to update the whole site to a new design, this will make it much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor greatly simplifies maintaining consistent styling and markup for the feature comparisons.
No content has been changed, except for fixing unnecessary blank lines at the start & end of the "Command line linter supports multiple files" code blocks on the PHP 8.3 release page.