Skip to content

Conversation

@iMattPro
Copy link
Contributor

No description provided.

@iMattPro iMattPro requested review from Copilot and rxu December 18, 2025 22:14
@iMattPro
Copy link
Contributor Author

Screenshot 2025-12-18 at 2 15 06 PM Looks like this

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the web push notification popup prompt by renaming terminology from "decline" to "deny", enhancing the visual design with an icon and flexbox layout, and refactoring JavaScript code for better organization and maintainability.

Key Changes:

  • Renamed "decline" terminology to "deny" across all code, tests, and translations
  • Added visual icon (bell with comment bubble) to popup title with flexbox layout
  • Refactored JavaScript localStorage functions into a promptDenied object and moved 'use strict' declarations to function scopes

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/functional/functional_test.php Updated test assertion to check for renamed button ID wpn_popup_deny
styles/all/theme/phpbb_wpn.css Added flexbox styling to popup title and renamed CSS classes from decline to deny
styles/all/template/webpush_popup.html Added icon stack to title and renamed button ID/class from decline to deny
styles/all/template/webpush.js Refactored localStorage functions into promptDenied object, moved 'use strict' declarations, and updated variable/function names
language/ru/webpushnotifications_module_ucp.php Updated Russian translation key from POPUP_DECLINE to POPUP_DENY
language/en/webpushnotifications_module_ucp.php Updated English translation key from POPUP_DECLINE to POPUP_DENY
language/en/webpushnotifications_module_acp.php Updated help text from "declined" to "denied"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@rxu rxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bubble doesn't look consistent as it seems to imply some origin the bubble goes from, which doesn't exist. Just bell in circle would be fine, as for me.

Another thing is that prompt window design is linked to all styles but it can be inconsistent with some (f.e. dark or game dedicated ones and so on). Probably it will make sense to move it to prosilver only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants