-
Notifications
You must be signed in to change notification settings - Fork 2
Improve prompt popup #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve prompt popup #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the web push notification popup prompt by renaming terminology from "decline" to "deny", enhancing the visual design with an icon and flexbox layout, and refactoring JavaScript code for better organization and maintainability.
Key Changes:
- Renamed "decline" terminology to "deny" across all code, tests, and translations
- Added visual icon (bell with comment bubble) to popup title with flexbox layout
- Refactored JavaScript localStorage functions into a
promptDeniedobject and moved'use strict'declarations to function scopes
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/functional/functional_test.php | Updated test assertion to check for renamed button ID wpn_popup_deny |
| styles/all/theme/phpbb_wpn.css | Added flexbox styling to popup title and renamed CSS classes from decline to deny |
| styles/all/template/webpush_popup.html | Added icon stack to title and renamed button ID/class from decline to deny |
| styles/all/template/webpush.js | Refactored localStorage functions into promptDenied object, moved 'use strict' declarations, and updated variable/function names |
| language/ru/webpushnotifications_module_ucp.php | Updated Russian translation key from POPUP_DECLINE to POPUP_DENY |
| language/en/webpushnotifications_module_ucp.php | Updated English translation key from POPUP_DECLINE to POPUP_DENY |
| language/en/webpushnotifications_module_acp.php | Updated help text from "declined" to "denied" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
392a9fb to
d09ad3b
Compare
rxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bubble doesn't look consistent as it seems to imply some origin the bubble goes from, which doesn't exist. Just bell in circle would be fine, as for me.
Another thing is that prompt window design is linked to all styles but it can be inconsistent with some (f.e. dark or game dedicated ones and so on). Probably it will make sense to move it to prosilver only.

No description provided.