Update attachment package #735
Conversation
🦋 Changeset detectedLatest commit: 9812964 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
This looks like a good improvement so far. I've added some comments for some items I spotted.
packages/attachments/src/storageAdapters/NodeFileSystemAdapter.ts
Outdated
Show resolved
Hide resolved
- Added `getAttachment` method to retrieve an attachment by ID in AttachmentContext. - Updated `upsertAttachment` to handle null values for optional fields. - Introduced `generateAttachmentId` method in AttachmentQueue for generating unique IDs. - Modified `watchActiveAttachments` to accept a throttle parameter. - Added `deleteFile` method to have attachment deletion. - Updated tests to cover new functionality and ensure reliability.
…ttachment sync operations - Added AttachmentErrorHandler interface to manage download, upload, and delete errors for attachments. - Updated AttachmentQueue and SyncingService to utilize the new error handler. - Enhanced tests to verify error handling behavior during attachment sync processes.
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
671e23a to
bea28d9
Compare
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
bea28d9 to
e42ae45
Compare
… across the react-native-web demo
# Conflicts: # pnpm-lock.yaml
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
Left some comments. Overall the APIs and code looks good so far.
demos/react-native-supabase-todolist/library/powersync/system.ts
Outdated
Show resolved
Hide resolved
packages/react-native/package.json
Outdated
| "dependencies": { | ||
| "@powersync/common": "workspace:*", | ||
| "@powersync/react": "workspace:*", | ||
| "expo-file-system": "18.0.12", |
There was a problem hiding this comment.
I assume this would not work on non-Expo React Native projects? One would need to confirm this dependency does not cause any issues on bare React native projects.
There was a problem hiding this comment.
It requires an expo project unfortunately. But, currently looking at @dr.pogodin/react-native-fs an active fork of react-native-fs, which works on native.
One question about including it as a direct dependency. I was thinking of going the dynamic import + optional peer dependency route (similar to react-native-quick-sqlite), you see any potential pitfalls?
There was a problem hiding this comment.
I've seen before, in the past, that nested direct dependencies sometimes aren't detected and installed correctly in the Expo build process. This might have changed at some point though.
Generally, an optional peer dependency would follow our current patterns. Dynamic imports with Metro have been a pain in the past, however if one follows the same patters as React Native Quick SQLite, I think we should be fine.
There was a problem hiding this comment.
I kept both, just for better coverage. I think catering for both Expo and vanilla React Native projects would be worthwhile. I understand there is a maintenance burden with supporting both adapters.
The vanilla implementation works on Expo as well, so let me know if you think this is redundant.
This a port of the Swift, Dart and Kotlin attachment's API to the JS SDK.
This addresses the following issues #715 and #714 by adding the
meta_datacolumn to the table and persisting it in the attachments table.It is currently still a work-in-progress so there are a couple things that still needs to be done: